On 19/12/2016 16:14, Larry Garfield wrote:
The spec was non-trivially altered just recently, wasn't it? That means
the 2 week review period needs to be reset, so people have a chance to
review the latest changes and give feedback if necessary.
No it wasn't non-trivially altered. I did two changes recently which you
suggested a long time ago and were anyway kinda trivial, namely:
- Add Data section from PSR-6 (which was implicit before I guess)
- Use `iterable` type hint (which replaces array|Traversable, and is
100% equivalent, just phpdoc sugar).
For instance, it looks like getMultiple() Is still taking an iterable
for $keys, whereas PSR-6 wants a straight array there. That's something
a few people had pushed back on before, but doesn't appear to have been
corrected. (*Returning* iterable is fine; asking for an iterable on
keys is just unnecessary complexity.)
That you disagree, or even a few people disagree, doesn't mean it has to
lead to a spec change IMO. This "unnecessary complexity" means PSR-6
adapters have to call iterator_to_array() on the $keys arg before
passing it downstream, it's like 1-2 lines of code times 3 functions.
It's kind of a nitpick, and I would personally not call this complexity.
It allows for a few more use cases at very little cost for implementors.
And finally this isn't trying to push the vote quickly before FIG 3,
this is trying to finally pass it so I can move on to other things,
because it has been implemented by a few projects already and they gave
feedback and we updated a few things and now it's been two weeks without
much of anything happening.
Best,
Jordi
--
Jordi Boggiano
@seldaek - http://seld.be
--
You received this message because you are subscribed to the Google Groups "PHP
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to php-fig+unsubscr...@googlegroups.com.
To post to this group, send email to php-fig@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/php-fig/2ab90cac-4cbc-9287-371e-b1c6b09ecc9a%40seld.be.
For more options, visit https://groups.google.com/d/optout.
