Thanks David for the summary and those PRs.
PR 1 sounds like the best solution to me. I can live with PR 2 or PR 3 if it helps the adoption of this PSR, I think PSR-11 would be better without these but it's my opinion and I see that as a minor detail. Matthieu Le Lun 16 janv 2017, à 11:58, David Négrier a écrit : > Ok, we have 3 options, and one day to decide which to choose. > > In order to ease the choice, I opened 3 PRs on Github. > > I'll ask everyone involved to give feedback on the 3 PRs. > > Let me present them briefly. > > *PR 1: Status Quo: NotFoundExceptionInterface CANNOT bubble up, but we > do not standardize MissingDependencyException* > Link: https://github.com/php-fig/fig-standards/pull/870/files > > This PR simply improves the current wording. It is easier to > understand but is strictly equivalent to PSR-11 as it is today. > > > *PR 2: NotFoundExceptionInterface CAN bubble up* > Link: https://github.com/php-fig/fig-standards/pull/869/files > > This PR let's NotFoundExceptionInterface bubble up. So a > `NotFoundExceptionInterface` means either "entry not found" OR > "missing dependency". The user can make the difference between the 2 > using the `has` method. > > *PR 3: NotFoundExceptionInterface CANNOT bubble up, but we add a > MissingDependencyException* > Link: https://github.com/php-fig/fig-standards/pull/871/files > > This PR adds an explicit MissingDependencyExceptionInterface. > > > Could I ask each of you to have a brief look at these PR and to tell > us how you like those? > Also, for the voting member, please indicate* if one of these PRs > would change your vote* from -1 to +1 (or the other way around) > > > Ok, so I'm opening this "flash poll" so I'll start: > > *PR 1: Status Quo * > https://github.com/php-fig/fig-standards/pull/870/files > > ++: I'm happy with the rewording, thanks to Nicolas comments. > > > *PR 2: NotFoundExceptionInterface CAN bubble up * > https://github.com/php-fig/fig-standards/pull/869/files > > ++: I'm equally happy with this proposal. Looking at most container- > interop implementations (for instance acclimate), they failed to > propertly prevent NotFoundExceptionInterface from bubbling up. So they > are actually already implementing this PR (by accident). > > *PR 3: NotFoundExceptionInterface CANNOT bubble up, but we add a > MissingDependencyException * > https://github.com/php-fig/fig-standards/pull/871/files > > -: I could perfectly live with an explicit > MissingDependencyExceptionInterface (it cannot break anything), but as > explained earlier, I find no good reason to catch it, and it prevents > us from migration Container-interop to PSR-11 automatically. So if > possible, I'd like to avoid that (but this is not a show stopper for > me and I'm ok to go that way if needed) > > Please answer this as soon as possible (since if we do any big changes > to the PSR, tomorrow is the last day we can put PSR-11 for review). > > ++ > David. > > -- > You received this message because you are subscribed to a topic in > the Google Groups "PHP Framework Interoperability Group" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/php-fig/I1a2Xzv9wN8/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > php-fig+unsubscr...@googlegroups.com. > To post to this group, send email to php-fig@googlegroups.com. > To view this discussion on the web visit > > https://groups.google.com/d/msgid/php-fig/398f3c10-6e15-4248-ae89-2193968cffa7%40googlegroups.com[1]. > For more options, visit https://groups.google.com/d/optout. Links: 1. https://groups.google.com/d/msgid/php-fig/398f3c10-6e15-4248-ae89-2193968cffa7%40googlegroups.com?utm_medium=email&utm_source=footer -- You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group. To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+unsubscr...@googlegroups.com. To post to this group, send email to php-fig@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/1484568237.4099876.849071224.703085F8%40webmail.messagingengine.com. For more options, visit https://groups.google.com/d/optout.
