hahah I don't always notice everything : )

-Jason
----- Original Message ----- 
From: "Joe Brown" <[EMAIL PROTECTED]>
To: ""Jason Greene"" <[EMAIL PROTECTED]>
Sent: Thursday, April 19, 2001 6:28 PM
Subject: Re: [PHP-CVS] cvs: php4 /ext/oci8 oci8.c


> Why didn't you Note to Not while you were at it?
> ----- Original Message -----
> From: ""Jason Greene"" <[EMAIL PROTECTED]>
> Newsgroups: php.cvs
> Sent: Thursday, April 19, 2001 6:00 PM
> Subject: [PHP-CVS] cvs: php4 /ext/oci8 oci8.c
> 
> 
> > jason Thu Apr 19 15:00:35 2001 EDT
> >
> >   Modified files:
> >     /php4/ext/oci8 oci8.c
> >   Log:
> >   Change all // to /* */, fixed small whitespace.
> >   Builds on Solaris now.
> >
> >
> > Index: php4/ext/oci8/oci8.c
> > diff -u php4/ext/oci8/oci8.c:1.117 php4/ext/oci8/oci8.c:1.118
> > --- php4/ext/oci8/oci8.c:1.117 Sat Apr 14 02:51:29 2001
> > +++ php4/ext/oci8/oci8.c Thu Apr 19 15:00:34 2001
> > @@ -20,7 +20,7 @@
> >
> +----------------------------------------------------------------------+
> >   */
> >
> > -/* $Id: oci8.c,v 1.117 2001/04/14 09:51:29 thies Exp $ */
> > +/* $Id: oci8.c,v 1.118 2001/04/19 22:00:34 jason Exp $ */
> >
> >  /* TODO list:
> >   *
> > @@ -584,7 +584,7 @@
> >
> >   php_info_print_table_start();
> >   php_info_print_table_row(2, "OCI8 Support", "enabled");
> > - php_info_print_table_row(2, "Revision", "$Revision: 1.117 $");
> > + php_info_print_table_row(2, "Revision", "$Revision: 1.118 $");
> >  #ifndef PHP_WIN32
> >   php_info_print_table_row(2, "Oracle Version", PHP_OCI8_VERSION );
> >   php_info_print_table_row(2, "Compile-time ORACLE_HOME", PHP_OCI8_DIR );
> > @@ -788,14 +788,14 @@
> >  _oci_coll_list_dtor(zend_rsrc_list_entry *rsrc)
> >  {
> >   oci_collection *coll = (oci_collection *)rsrc->ptr;
> > -    oci_debug("START _oci_coll_list_dtor: %d",coll->id);
> > + oci_debug("START _oci_coll_list_dtor: %d",coll->id);
> >
> >   zend_list_delete(coll->conn->id);
> > - // Note sure if we need to free the object.  Have an
> > -    // oracle TAR out on this one.
> > - //    OCIDescriptorFree(descr->ocidescr, descr->type);
> > + /* Note sure if we need to free the object.  Have an
> > +     oracle TAR out on this one.
> > +     OCIDescriptorFree(descr->ocidescr, descr->type); */
> >
> > -    oci_debug("END   _oci_coll_list_dtor: %d",coll->id);
> > + oci_debug("END   _oci_coll_list_dtor: %d",coll->id);
> >
> >   efree(coll);
> >  }
> > @@ -5099,7 +5099,7 @@
> >          RETURN_FALSE;
> >      }
> >
> > -   // get the collection type code of the attribute
> > +   /* get the collection type code of the attribute */
> >     connection->error = OCIAttrGet((dvoid*) parmp1, (ub4) OCI_DTYPE_PARAM,
> >                        (dvoid*) &(coll->coll_typecode), (ub4 *) 0,
> >                        (ub4) OCI_ATTR_COLLECTION_TYPECODE,
> >
> >
> >
> > --
> > PHP CVS Mailing List (http://www.php.net/)
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> > To contact the list administrators, e-mail: [EMAIL PROTECTED]
> >
> 
> 


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Reply via email to