John Nichel wrote:
Adam Williams wrote:
I have a file called userlist. I'm trying to read the file, and then echo their name and add @mdah.state.ms.us with it. In the file userlist, it looks like:

userabc
userdef
userxyz

and I have the following code:

<?php
$filename = "userlist";
$fp = fopen($filename, "r") or die ("Couldn't open $filename");
if ($fp)
{
while (!feof($fp))
       {
       $thedata = fgets($fp);
       if ($thedata != "")
               {
               echo "$thedata"."@mdah.state.ms.us";
               }
       }
fclose($fp);
}
?>


But when I run it, I get:

@mdah.state.ms.ususerabc
@mdah.state.ms.ususerdef
@mdah.state.ms.ususerxyz

and I am expecting to get:

[EMAIL PROTECTED]
[EMAIL PROTECTED]
[EMAIL PROTECTED]

So can someone look at my code and let me know why I'm not getting my expected output?


Well, you're not telling fgets how much to read for one, and I'd do this a different way to begin with...

if ( $file = file ( $filename ) ) {
    foreach ( $file as $line ) {
        if ( $file != "" ) {

Oops, should be...

          if ( $line != "" ) {

            echo ( $line . "@mdah.state.ms.us" );
        }
    }
} else {
    echo ( "Couldn't open $filename" );
}



--
John C. Nichel IV
Programmer/System Admin (ÜberGeek)
Dot Com Holdings of Buffalo
716.856.9675
[EMAIL PROTECTED]

--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to