On 13/06/07, Richard Davey <[EMAIL PROTECTED]> wrote:
Hi Robert,Wednesday, June 13, 2007, 3:15:39 PM, you wrote: > It's terribly verbose and inefficient... > <?php > $filter['flags'] = 0; > if( $allow_fraction ) > { > $filter['flags'] |= FILTER_FLAG_ALLOW_FRACTION; > } > if( $allow_thousand ) > { > $filter['flags'] |= FILTER_FLAG_ALLOW_THOUSAND; > } > if( $allow_scientific ) > { > $filter['flags'] |= FILTER_FLAG_ALLOW_SCIENTIFIC; > } ?>> I don't think it's *terribly* verbose, as it has good sentence structure to it, but your version is certainly more efficient, hence I've swapped to that. Any other takers? ;)
lose the conditionals? $filter['flags'] = 0; $allow_fraction && $filter['flags'] |= FILTER_FLAG_ALLOW_FRACTION; $allow_thousand && $filter['flags'] |= FILTER_FLAG_ALLOW_THOUSAND; $allow_scientific && $filter['flags'] |= FILTER_FLAG_ALLOW_SCIENTIFIC; or keep the conditionals and just do one assignment? $filter['flags'] = ($allow_fraction ? FILTER_FLAG_ALLOW_FRACTION : 0) | ($allow_thousand ? FILTER_FLAG_ALLOW_THOUSAND : 0) | ($allow_scientific ? FILTER_FLAG_ALLOW_SCIENTIFIC : 0); as the perl motto says, "there's more than one way to do it". -robin -robin -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
