So I agree with your patch. :)

Probaly gettype() and settype() must be changed in the same way.

Thanks. Dmitry.

> -----Original Message-----
> From: Derick Rethans [mailto:[EMAIL PROTECTED] 
> Sent: Wednesday, March 15, 2006 2:45 PM
> To: Dmitry Stogov
> Cc: 'Marcus Boerger'; 'Unicode Mailinglist'
> Subject: RE: [PHP-I18N] is_string()
> 
> 
> On Wed, 15 Mar 2006, Dmitry Stogov wrote:
> 
> > In  case of "> is_string(): Z_TYPE_P() == IS_STRING  || 
> Z_TYPE_P() == 
> > IS_UNICODE",
> > is_string() will return TRUE for binary data in unicode mode.
> > 
> > It should be:
> > is_string(): Z_TYPE_P() == (UG(unicode)?IS_UNICODE:IS_STRING)
> > 
> > is_binary() and is_unicode() are OK.
> 
> That's what my patch does...
> 
> Derick
> -- 
> Derick Rethans
> http://derickrethans.nl | http://ez.no | http://xdebug.org
> 
> -- 
> PHP Unicode & I18N Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
> 
> 
> 

-- 
PHP Unicode & I18N Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to