On Jul 25, 2014 4:05 PM, "christopher jones" <christopher.jo...@oracle.com> wrote: > > > Thanks for running the testfest. > > Chris > > > On 7/25/14, 7:35 AM, Rogerio Prado de Jesus wrote: >> >> Hi, Ferenc, >> >> The event ran good (feedbacks in https://joind.in/event/view/2258) and >> probably we will do periodic test fest here in São Paulo, Brazil >> (https://github.com/PHPSP/hexagon-project/issues/14). >> >> Anyway, now you are closing the event by send the Pull Requests to >> https://github.com/php/php-src. >> >> I've a question, please help us: >> >> >> We have some test contributions that targets not only PHP-5.6, but >> PHP-5.5 and master as well. >> >> For every pull request to PHPSP fork, we are going to create three >> branches in (eg. phpsp-pr000-php-5.5, phpsp-pr000-php-5.6 and >> phpsp-pr000-master), and eventually send three pull requests to core >> from PHPSP fork. >> >> # Example: >> >> ## Contributed tests: >> >> https://github.com/PHPSP/php-src/pull/2. >> >> ## Branches created in PHPSP fork: >> >> - https://github.com/PHPSP/php-src/tree/phpsp-pr002-php-5.6 >> - https://github.com/PHPSP/php-src/tree/phpsp-pr002-PHP-5.5 >> - https://github.com/PHPSP/php-src/tree/phpsp-pr002-master >> >> ## Pull requests from PHPSP fork to php/php-src core: >> >> - https://github.com/php/php-src/pull/742 (5.5) >> - https://github.com/php/php-src/pull/743 (5.6) >> - https://github.com/php/php-src/pull/744 (master) >> >> Is that correct? Can I continue with the other contributions we have? >> Or you guys suggest a better path? >> >> Thanks in advance! >> >> Rogerio >> rogeriopra...@php.net >> rogeriopra...@gmail.com >> rogeriopradoj.com >> >> >> On Sun, Jun 22, 2014 at 3:33 PM, Ferenc Kovacs <tyr...@gmail.com> wrote: >>> >>> >>> >>> >>> On Sun, Jun 22, 2014 at 12:57 AM, Rogerio Prado de Jesus >>> <rogeriopra...@gmail.com> wrote: >>>> >>>> >>>> Hi, >>>> >>>> I'm Rogerio, one of the currently active Evangelists at PHPSP (PHP São >>>> Paulo User Group), from Brazil, and we are planing to organizing a >>>> Test Fest here in São Paulo, SP, Brazil, two weeks in advance, July 5. >>>> >>>> We'd like some help on how we should do the things: >>>> >>>> 1. Should we focus on testing (PHPT) PHP 5.6 or PHP 5.6 (our members >>>> are choosing 5.6, 83%, and 5.5, 17%)? >>>> >>>> 2. Which is the base git branch we should use for sending pull >>>> requests? PHP-5.6 and PHP-5.5? Or master? >>>> >>>> 3. Could we guide contributors to fork php-src repository and send >>>> Pull Requests directly to original/upstream? Or should we create a >>>> repository in-the-middle to concentrate the contributions (and after >>>> sending one huge Pull Request)? >>>> >>>> 3.1 About the pull requests, prior everyone of them, should we send a >>>> message to the mailing list, or it's not really need? >>>> >>>> >>>> So, that's it. >>>> >>>> >>>> In time, PHPSP User Group already hosted some events in the past in >>>> order to participate of global PHP TestFest 2009 and 2010 as well. >>>> >>>> Thanks in advance >>>> >>>> Rogerio >>>> rogeriopradoj.com >>>> ᐧ >>>> >>>> -- >>>> PHP Quality Assurance Mailing List <http://www.php.net/> >>>> To unsubscribe, visit: http://www.php.net/unsub.php >>>> >>> >>> Hi, >>> >>> 1, I think 5.6 would be better, but I'm a bit biased being one of the RMs >>> for that release. :P >>> >>> 2, Generally I think that test related PRs should target the lowest >>> available branch which it affects, as it is always ok to merge test related >>> fixes/more tests, but if you want to focus a specific branch, I think you >>> should also target that branch with the PRs. >>> >>> 3, Huge PRs are a bad thing (harder to review, harder to cherry-pick, nobody >>> is daring enough to merge the whole thing, etc.), but maybe it would be nice >>> if instead of 100 people sending 100 PR from 100 fork, you could have one >>> repo/organization and sending the PRs there. That would allow us to see >>> easily what PRs are from you guys, and still keep them separate PRs. >>> >>> 3.1, I don't think every PR needs a mail, but please don't hesitate to send >>> an email (or drop by irc) if you have any questions or bumping into a >>> problem, I will try to answer it quickly. >>> >>> Thanks for organizing this, and helping the project! >>> >>> -- >>> Ferenc Kovács >>> @Tyr43l - http://tyrael.hu >> >> >> ᐧ >> > > -- > christopher.jo...@oracle.com http://twitter.com/ghrd > Free PHP & Oracle book: > http://www.oracle.com/technetwork/topics/php/underground-php-oracle-manual-098250.html
Our pleasure, Chris! -- Rogerio
