On 03.08.2016 at 12:07, Kalle Sommer Nielsen wrote:
> 2016-08-03 11:34 GMT+02:00 Christoph Becker <cmbecke...@gmx.de>:
>
>> The first test[1] is supposed to be run on Windows systems only. I'm
>> rather surprised that apparently your system reports the following to be
>> false:
>>
>> substr(PHP_OS, 0, 3) != 'WIN'
>
> Could be a casing issue? I believe we usually check for Windows like:
>
> if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
> // Win32
> }
Yes, that should indeed be fixed. However, in the case Peter reported,
apparently PHP_OS starts with "WIN", and that would almost certainly be
a bug for OS X. OTOH, the other test would have been skipped in this
case, so I'm somewhat confused.
The only thing I can faintly imagine, is that PHP_OS would be 0 on this
machine (0 == "WIN" in PHP), but that would also certainly be a bug.
--
Christoph M. Becker
--
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php
