Edit report at https://bugs.php.net/bug.php?id=73582&edit=1

 ID:                 73582
 Updated by:         c...@php.net
 Reported by:        a...@php.net
 Summary:            Failing ext/gd/tests/imagettftext_charmap_order.phpt
-Status:             Verified
+Status:             Closed
 Type:               Bug
 Package:            Testing related
 Operating System:   FreeBSD, Linux
 PHP Version:        Irrelevant
 Assigned To:        cmb
 Block user comment: N
 Private report:     N

 New Comment:

Automatic comment on behalf of cmbecke...@gmx.de
Revision: 
http://git.php.net/?p=php-src.git;a=commit;h=7f529e3dee032d5977166c3eb7b70f57edc8e562
Log: Fix #73582: Failing ext/gd/tests/imagettftext_charmap_order.phpt


Previous Comments:
------------------------------------------------------------------------
[2016-11-24 14:42:22] c...@php.net

Thanks for the quick confirmation. For me, the test fails even
with freetype 2.6.5 with `--enable-gd-jis-conv`. I wonder what the
image looks like in environments where the test suceeds with
`--enable-gd-jis-conv`. The expected image would be something like
<http://imgur.com/gallery/AETBl>.

There may indeed be issues with `--enable-gd-jis-conv`, but there
are definitely general issues with GD's freetype support[1][2],
besides that gdft.c has diverged between external and bundled
libgd, so IMHO, for now it might be best to just skip the test if
PHP has been built with JIS-mapped Japanese Font Support, i.e.
adding the following to the SKIPIF section:

  if(gd_info()['JIS-mapped Japanese Font Support'])
     die('skip JIS-mapped Japanese Font Support not supported');

[1] 
<https://bugs.php.net/search.php?cmd=display&bug_type=All&status=Open&package_name%5B%5D=GD+related&by=Any&limit=30>
[2] 
<https://github.com/libgd/libgd/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20text>

------------------------------------------------------------------------
[2016-11-24 12:39:14] a...@php.net

Thanks for looking into this again :) I obviously lost --enable-gd-jis-conv in 
the description, but it is indeed present in my config. Though, causing the 
test to fail only in certain env. Looks like there was always some bug, as the 
test is present for longer already, despite it doesn't fail with newer freetype.

Thanks.

------------------------------------------------------------------------
[2016-11-24 12:12:23] c...@php.net

Well, I tried again, and I can reproduce if I configure with
`--enable-gd-jis-conv`. Not sure, if that's the problem you've
found, but at least this has to be fixed. I'll look into it.

------------------------------------------------------------------------
[2016-11-24 10:28:21] a...@php.net

If it helps, i've reproduced the fail on Jessie as well, with the shipped 
freetype 2.5.2. I couldn't work on this in short term as well :/

Thanks.

------------------------------------------------------------------------
[2016-11-23 17:11:36] c...@php.net

I've still not been able to reproduce the failing test. I've tried
on Debian 8.4 with the default freetype2 package (2.5.2) and a
self-compiled freetype-2.5.2 one, and on FreeBSD 10.3 with the
default freetype2 package(2.6.3) and with the
freetype2-2.5.0.1.txz and freetype2-2.5.3_2.txz package. The test
always passes here.

> Freetype 2.5.2, unfortunately I can't tell much about its
> configuration, as it's a precompiled package from the distro.

I have not been able to find a FreeBSD freetype-2.5.2 package. :/

I'm afraid, I can't help here.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=73582


--
Edit this bug report at https://bugs.php.net/bug.php?id=73582&edit=1

-- 
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to