Edit report at https://bugs.php.net/bug.php?id=78115&edit=1
ID: 78115
User updated by: v-altruo at microsoft dot com
Reported by: v-altruo at microsoft dot com
Summary: Output mismatch
-Status: Feedback
+Status: Assigned
Type: Bug
Package: Testing related
Operating System: Windows
PHP Version: 7.3.6
Assigned To: cmb
Block user comment: N
Private report: N
New Comment:
The test is skipped for:
if (false == setlocale(LC_CTYPE, "UTF8")) {
Test fails for:
if (false == setlocale(LC_CTYPE, "en_US.UTF8")) {
Previous Comments:
------------------------------------------------------------------------
[2019-06-24 15:19:47] [email protected]
Please change the skip-if clause[1] to
if (false == setlocale(LC_CTYPE, "UTF8")) {
and
if (false == setlocale(LC_CTYPE, "en_US.UTF-8")) {
and run the test again (i.e. two runs). Is the test skipped for either variant?
[1]
<https://github.com/php/php-src/blob/php-7.3.6/sapi/cli/tests/bug44564.phpt#L5>
------------------------------------------------------------------------
[2019-06-11 17:44:47] v-altruo at microsoft dot com
Prior to this I did not run this test with pftt. I only ran it with
run-test.php and it failed.
However, now I tried to run it with pftt (with the suggested fix) and
run-tests.php and it still fails instead of skipping.
------------------------------------------------------------------------
[2019-06-11 10:33:36] [email protected]
Thanks for the feedback!
If you used PFFT2, please double-check with run-tests.php, or try
<https://github.com/php/pftt2/pull/41>.
------------------------------------------------------------------------
[2019-06-06 18:54:39] v-altruo at microsoft dot com
Previously, on 7.2.19RC1 and 7.3.6RC1 builds, it failed for me as well.
However, when I had someone else check it, it skipped for them. This time
around it seems to have not skipped for either of us.
Using the snap for the fix related to locales.phpt, it still didn't pass/skip
this particular test when I tried it.
------------------------------------------------------------------------
[2019-06-06 08:28:57] [email protected]
Thanks for reporting!
Actually, this test is supposed to be skipped on Windows[1], since
neither of the given locales is supposed to be accepted there. It
is indeed skipped when I run locally, and on AppVeyor[2] as well.
On my machine, it would not be skipped, however, if I changed the
LC_CTYPE to LC_ALL.
Anyhow, this issue should be fixed with the suggested fix for bug
#77937[3]. Please check whether this is indeed the case.
[1]
<https://github.com/php/php-src/blob/php-7.3.6/sapi/cli/tests/bug44564.phpt#L5>
[2]
<https://ci.appveyor.com/project/php/php-src/builds/25063179/job/hnobwca23aq8fnle#L5677>
[3] <https://github.com/php/php-src/pull/4169>
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=78115
--
Edit this bug report at https://bugs.php.net/bug.php?id=78115&edit=1
