On Sun, Aug 25, 2013 at 9:29 PM, Sherif Ramadan <[email protected]>wrote:
> On Sun, Aug 25, 2013 at 11:22 PM, Levi Morrison > <[email protected]>wrote: > >> I'm not sure what regression you are talking about, but I'm sorry if it >> was me that killed it. We'd like to not use the full jQuery UI library as >> it is huge and we use such a small portion. If we do add it back in we >> should include the components we need. >> > > I'm referring to http://php.net/65402 and, no the git blame appears not > to point to you. If I'm not mistaken, according to the existing code in > both branches we are already loading the UI. Not sure why you want to > remove it, really. To me, 50KB is not huge and considering that we load > from Google, you can pretty much count on a huge chunk of users having that > in browser cache. > Having a 50Kb dependency that we only use <10KB doesn't make sense at all, especially when you consider how fast we want PHP.net to be. The new design is considerably slower to load and plenty of users have complained about it in the feedback tool. Some of it is that we don't cache the css files, but we simply have more files we include. I've already done some work to lessen the load, but my very unofficial tests on my server show it's still quite a bit slower. The jQuery UI was the easiest thing to kill with the biggest gain when not loading from cache. Even if we do add things back in, can we please build it component by component? I don't think as many people have version X of jQuery UI in cache as you think.
