Commit:    2523e3c0a3d12ef8ed0a5c43d516fdc13b4ac2f2
Author:    Hannes Magnusson <[email protected]>         Tue, 10 Dec 2013 
15:14:18 -0800
Parents:   eb6caa671a8b8e0a58632c43709a3b18c2c74d13
Branches:  master

Link:       
http://git.php.net/?p=web/php.git;a=commitdiff;h=2523e3c0a3d12ef8ed0a5c43d516fdc13b4ac2f2

Log:
Hopefully prettify

Changed paths:
  M  build-setup.php
  M  get-involved.php
  M  styles/theme-base.css


Diff:
diff --git a/build-setup.php b/build-setup.php
index 790beb7..8735421 100644
--- a/build-setup.php
+++ b/build-setup.php
@@ -13,7 +13,8 @@ $SIDEBAR_DATA ='
 site_header("Get Involved", array("current" => "community"));
 
 ?>
-<h2>Operating System Preparation</h2>
+<h2 id="os-prep" class="content-header">Operating System Preparation</h2>
+<div class="content-box">
 <p>
     Improving PHP requires a working build environment to test changes, the 
following section deals with setting up a working build environment.
 </p>
@@ -25,17 +26,17 @@ site_header("Get Involved", array("current" => 
"community"));
     For most *nix like operating systems, some external dependencies may be 
required to bring a build to completion; 
         if a build fails because of missing headers or libraries, issuing a 
variant of the following command should resolve those dependencies, allowing 
the build to continue:
     <ul>
-        <li>[sudo] yum|apt-get|ports install package[-dev[el]]</li>
+        <li><pre>[sudo] yum|apt-get|ports install package[-dev[el]]</pre></li>
     </ul>
 </p>
 <p>
     For those working in <i>Ubuntu Linux</i>, you can run the following 
command to automate the installation of dependencies:
     <ul>
-        <li>sudo apt-get build-dep php5</li>
+        <li><pre>sudo apt-get build-dep php5</pre></li>
     </ul>
     If the compilation of <i>an extension</i> should fail because of missing 
dependencies, <i>Ubuntu Linux</i> can attempt to automate the resolution of 
those dependencies by issuing:
     <ul>
-        <li>sudo apt-get build-dep php5-<i>extname</i></li>
+        <li><pre>sudo apt-get build-dep php5-<i>extname</i></pre></li>
     </ul>
 </p>
 <p>
@@ -82,8 +83,10 @@ site_header("Get Involved", array("current" => "community"));
 </tr>
 </table>
 <p><b>Note:</b>&nbsp;If a Windows SDK is required, it is advised to install 
the SDK <i>before</i> Visual Studio.</p>
+</div>
 
-<h2>Workspace Preparation</h2>
+<h2 id="workspace-prep" class="content-header">Workspace Preparation</h2>
+<div class="content-box">
 <p>
     Windows users should now download and unzip the PHP SDK to their workspace 
and execute the following commands in an appropriate Visual Studio Console:
 </p>
@@ -103,20 +106,24 @@ site_header("Get Involved", array("current" => 
"community"));
 <p>
     The next step for everyone is to obtain the versioned PHP sources via git:
     <ul>
-        <li>git clone -b BRANCH https://github.com/php/php-src .</li>
+        <li><pre>git clone -b BRANCH https://github.com/php/php-src 
.</pre></li>
     </ul>
     BRANCH should be replaced with an appropriate branch name, for example 
<i>PHP-5.5</i>.
 </p>
 <p>
     At this point you have a working build environment and the vanilla sources 
for your chosen branch of PHP, it is a good idea, before you change anything at 
all, to create a new branch and switch to it, in preparation for your awesome 
changes to come:
     <ul>
-        <li>git checkout -b my-awesome-changes</li>
+        <li><pre>git checkout -b my-awesome-changes</pre></li>
     </ul>
 </p>
-<h2>Building Your Development PHP</h2>
+</div>
+
+
+<h2 id="build-dev" class="content-header">Building Your Development PHP</h2>
+<div class="content-box">
 <p>
     All operating systems now converge on (near as makes no difference) the 
same solutions for the rest of the build process:
-    <ul>
+    <ul class="listed">
         <li>buildconf: generates the configure script for PHP</li>
         <li>configure: configures the build of PHP and creates Makefile</li>
         <li>make: builds PHP</li>
@@ -126,7 +133,7 @@ site_header("Get Involved", array("current" => 
"community"));
 </p>
 <p>
     For Microsoft Windows operating systems, those commands looks like this:
-    <ul>
+    <ul class="listed">
         <li>buildconf</li>
         <li>configure --with-prefix=C:\my-awesome-php</li>
         <li>nmake</li>
@@ -136,7 +143,7 @@ site_header("Get Involved", array("current" => 
"community"));
 </p>
 <p>
     While for the rest of us, those commands look like this:
-    <ul>
+    <ul class="listed">
         <li>./buildconf</li>
         <li>./configure --prefix=/opt/my-awesome-php</li>
         <li>make</li>
@@ -160,6 +167,7 @@ site_header("Get Involved", array("current" => 
"community"));
         <li>[n]make test TESTS=sapi/cli</li>
     </ul>
 </p>
+</div>
 <?php
 site_footer(array('sidebar'=>$SIDEBAR_DATA));
 
diff --git a/get-involved.php b/get-involved.php
index d176995..452493a 100644
--- a/get-involved.php
+++ b/get-involved.php
@@ -3,20 +3,11 @@
 $_SERVER['BASE_PAGE'] = 'get-involved.php';
 include_once $_SERVER['DOCUMENT_ROOT'] . '/include/prepend.inc';
 
-$SIDEBAR_DATA ='
-    <p>
-      Ever wondered how the PHP.net project actually works and what it has to 
offer? 
-      Who is in charge and how decisions are made? The PHP.net project has a 
lot of 
-      things in the works and is always looking for new talent to join the 
project, 
-      share new ideas, discuss improvements, fix broken features, look after 
the
-      websites, documentation, and so on....
-    </p>
-';
-
 site_header("Get Involved", array("current" => "community"));
 ?>
 
-<h2>Contributing to PHP</h2>
+<h2 class="content-title">Contributing to PHP</h2>
+<div class="content-box">
 
 <p>
  Anybody who programs in PHP can be a contributing member of the community
@@ -31,11 +22,11 @@ site_header("Get Involved", array("current" => 
"community"));
  but help is still needed: testing release candidates, finding and squashing
  bugs in tests, documentation, and sources.
 </p>
+</div>
 
-<h3>Four Best Ways to Contribute</h3>
+<h3 class="content-title">Four Best Ways to Contribute</h3>
 
-<p>
- <ol>
+ <ol class="content-box listed">
   <li>Running test suites in <a href="http://qa.php.net/";>RC</a>
       and <a href="http://php.net/releases";>release</a> distributions of 
PHP</li>
   <li>Help finding and diagnosing failed tests, see
@@ -45,10 +36,10 @@ site_header("Get Involved", array("current" => 
"community"));
   <li>Help maintain and or translate documentation files
       at <a href="http://edit.php.net";>edit.php.net</a></li>
  </ol>
-</p>
 
-<h3>Development of the PHP source</h3>
+<h3 class="content-header">Development of the PHP source</h3>
 
+<div class="content-box">
 <p>
  Someone hoping to become involved in the maintenance and development of
  the source should be experienced in all of the areas mentioned above, as
@@ -59,20 +50,23 @@ site_header("Get Involved", array("current" => 
"community"));
 <p>
  You will also need experience in C programming as PHP is written entirely in 
C.
 </p>
+</div>
 
-<p>
- Below are some useful links for developers:
-  <ul>
+
+<?php
+$SIDEBAR_DATA ='
+    <p class="panel"><a href="build-setup.php">Developer Setup Help</a></p>
+<h3 class="announcements">Useful links for developers:</h3>
+  <ul class="content-box">
    <li><a href="http://lxr.php.net";>lxr</a> - an online interface to the
        PHP source, providing search facilities useful for programmers and 
researchers</li>
    <li><a href="https://wiki.php.net/rfc/howto";>The RFC process</a> - the 
process
        by which developers can suggest and discuss new ideas with the 
community</li>
-   <li><a href="/build-setup">Developer Setup Help</a> - some helpful 
information
+   <li><a href="/build-setup.php">Developer Setup Help</a> - some helpful 
information
        regarding setting up a development environment for PHP</li>
   </ul>
-</p>
+';
 
-<?php
 site_footer(array('sidebar'=>$SIDEBAR_DATA));
 
 /* vim: set et ts=4 sw=4 ft=php: : */
diff --git a/styles/theme-base.css b/styles/theme-base.css
index 68fec70..1f8a400 100755
--- a/styles/theme-base.css
+++ b/styles/theme-base.css
@@ -2862,12 +2862,24 @@ fieldset {
 .content-header .changelog {
     color:#369;
 }
-.content-box ul, .content-box li {
+.content-box ul {
     list-style: none;
     display: block;
+}
+.content-box ul,
+.content-box li {
     margin: 0;
     padding: 0;
 }
+ul.listed,
+ol.listed {
+    list-style: disc;
+    display: block;
+}
+ul.listed,
+ol.listed li {
+    margin: 10px 30px;
+}
 .content-box li {
     margin-bottom: 0.75em;
 }


--
PHP Webmaster List Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to