On Wed, Jun 25, 2014 at 8:03 PM, Maciej Sobaczewski <so...@php.net> wrote:
> W dniu 2014-06-25 19:53, Ferenc Kovacs pisze: > > On Wed, Jun 25, 2014 at 7:04 PM, Hannes Magnusson < >> hannes.magnus...@gmail.com> wrote: >> >> On Wed, Jun 25, 2014 at 9:10 AM, Maciej Sobaczewski <so...@php.net> >>> wrote: >>> >>>> Hello folks! >>>> >>>> I've commited this as a temporary [really ;)] workaround for side bug >>>> reported here: https://bugs.php.net/bug.php?id=67513 As reporter wrote: >>>> >>>> >>>> (On an unrelated note, the issue tracker refused to accept my >>>>> submission >>>>> if I selected 'Irrelevant' as the PHP version. Therefore this bug is >>>>> randomly logged against a random PHP version) >>>>> >>>> >>>> >>>> This bug is caused by pull request merged recently because it fails on >>>> >>> our >>> >>>> custom versions like "Irrelevant" and "str_size_and_int64 branch". >>>> >>>> As my solution is poor and may lead to further problems (one more place >>>> >>> to >>> >>>> check), I have following idea: couldn't we add custom versions in >>>> includes/php_versions.php and then just generate them with foreach in >>>> show_version_options()? It seems to be more elegant way to achieve this. >>>> However, I know that web-bugs is rather complex system so I wanted to >>>> consult with you to avoid unexpected bugs (like I did week ago or so). >>>> >>>> What do you think? >>>> >>> >>> >>> I guess we should just revert https://github.com/php/web- >>> bugs/pull/9/files >>> >>> Like I told him, when editing the ticket we often want to triage the >>> version however we like so it is a bit dodgy validation anyway. >>> >>> -Hannes >>> >>> -- >>> PHP Webmaster List Mailing List (http://www.php.net/) >>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >>> >>> +1 for reverting it. >> >> Then I will rewrite it soon. What about reverting version validation? That was we were talking about. I've both the original validation and your workaround now. -- Ferenc Kovács @Tyr43l - http://tyrael.hu
