Levi Morrison wrote:
> On Wed, Mar 18, 2015 at 3:40 PM, Christoph Becker <[email protected]> wrote:
>
>> The error messages are at least used on the regristration page[1]. Try
>> to register and leave the fourth input field blank, for instance.
>>
>> I assume they are used on other pages as well, but I'm not sure (there
>> are many calls to msg() in DokuWiki, anyhow). The registration form
>> uses only class .error, but the other classes may be used somewhere else.
>>
>> [1] <https://wiki.php.net/rfc/?do=register>
>
> Thanks. I have a few questions:
>
> - what is the purpose of the reduced font size?
> - border-radius: 5px is too round; will you change it to 2px?
> - will you change the padding from 0.4em to 0.5em? (For reference,
> 0.5em and 0.75em are fairly common -- I don't think we use 0.4em
> anywhere)
I simply took the CSS rules from the current stock DokuWiki, and only
removed the background icons. I considered it most important to
highlight the messages in some way. Actually, I consider the reduced
font-size rather questionable, and personally I would prefer some more
horizontal margin. The border-radius is all the same to me.
It seems to be reasonable to adjust the styling to the php.net manual
pages, which has (more or less)
div.warning {
box-shadow: inset 0 0 0 1px rgba(0,0,0,.15);
border-radius: 0 0 2px 2px;
background: #F4DFDF;
border-color: #EABFBF;
padding: .75rem;
margin: 1.5rem 0;
overflow: hidden;
}
What do you think?
> Unrelated to this change, on that page there is this text:
>
>> To which email address do you have to send an email now?
>
> Do you know if that is a stock DokuWiki message or a custom one?
As Hannes already said, it is a custom message. See my comment on the
respective PR (<https://github.com/php/web-wiki/pull/5>). I'm sure, the
message can be improved -- any suggestions are welcome (I'm not a native
English speaker, obviously).
--
Christoph M. Becker
--
PHP Webmaster List Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
