Edit report at https://bugs.php.net/bug.php?id=74493&edit=1
ID: 74493
Comment by: jay at room11 dot org
Reported by: php-bugs-2014-08 at dotancohen dot com
Summary: Summary: On page links jump to incorrect anchors if
the name contains the target
Status: Verified
Type: Bug
Package: Website problem
PHP Version: Irrelevant
Assigned To: peehaa
Block user comment: N
Private report: N
New Comment:
@levi - All done
Previous Comments:
------------------------------------------------------------------------
[2017-04-25 14:30:54] [email protected]
I'm not entirely sure why someone did "contains" in the first place but I'm
inclined to believe there was actually a reason. I suppose we can commit this
with an added comment that mentions this bug so when we uncover the reason it
is like this we can do a proper fix.
------------------------------------------------------------------------
[2017-04-25 12:26:19] [email protected]
Jay created a PR for to fix this https://github.com/php/web-php/pull/154
If somebody with powers could review and merge that please.
------------------------------------------------------------------------
[2017-04-24 08:15:15] [email protected]
Ah, sorry @peehaa.
------------------------------------------------------------------------
[2017-04-24 08:14:26] [email protected]
Because it's de-limit-er.
https://github.com/php/web-php/blob/master/js/common.js#L411
'.parameters .parameter:contains("' + id + '"), .options
.parameter:contains("' + id + '")'
------------------------------------------------------------------------
[2017-04-24 08:04:32] [email protected]
The links jumps to de*limit*er. Basically the first *limit* param the JS sess.
Should probably be made more strict to only jump to exact matches.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=74493
--
Edit this bug report at https://bugs.php.net/bug.php?id=74493&edit=1
--
PHP Webmaster List Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
