Edit report at https://bugs.php.net/bug.php?id=78060&edit=1
ID: 78060 Updated by: [email protected] Reported by: [email protected] Summary: Large image sizes don't show properly Status: Open Type: Bug Package: Website problem PHP Version: Irrelevant Block user comment: N Private report: N New Comment: I was just trying to clarify what should be the existing process, and gave a personal opinion; not to dictate anything. I hope we can have differing thoughts and opinions yet still get a productive outcome. Previous Comments: ------------------------------------------------------------------------ [2019-05-24 09:35:47] [email protected] Well, we could set up a pre-commit hook where the image size would be checked. ------------------------------------------------------------------------ [2019-05-24 09:30:52] [email protected] Ok... :) I think that this is wrong approach, but your call here. I don't merge pull requests there so I'm sure you'll catch it on time then. ------------------------------------------------------------------------ [2019-05-24 09:27:51] [email protected] This should be being caught when reviewing the Pull Requests. Any PRs with huge images should not be approved until an appropriately-sized image is used instead. If a commit doesn't go through the review system and a huge image does added to the repo, then I would rather it be displayed as huge so we can notice the issue and get the image resized. ------------------------------------------------------------------------ [2019-05-24 08:56:00] [email protected] Description: ------------ Leftover from my very long TODO list of bugs for these PHP sites - maybe someone who will be fixing these sites will have motivation to fix them. http://php.net/conferences/ ^ here if the image size is too big (let's say 1600x800) there should be limit in CSS to scale such image responsively to a max width. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=78060&edit=1 -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
