Author: Christoph M. Becker (cmb69)
Committer: GitHub (web-flow)
Pusher: cmb69
Date: 2022-07-29T18:08:54+02:00

Commit: 
https://github.com/php/web-php/commit/29f24d095cb14457a50a3ef8c495bafb82a8b767
Raw diff: 
https://github.com/php/web-php/commit/29f24d095cb14457a50a3ef8c495bafb82a8b767.diff

Fix GH-676: Releases RSS/ATOM feed does not validate

The feed's updated element is required before the entries.

Closes GH-678.

Changed paths:
  M  releases/feed.php


Diff:

diff --git a/releases/feed.php b/releases/feed.php
index bfcf2417d..8df9155e4 100644
--- a/releases/feed.php
+++ b/releases/feed.php
@@ -18,6 +18,8 @@
 
 XML;
 
+ob_start();
+
 // Flatten major versions out of RELEASES.
 $RELEASED_VERSIONS = array_reduce($RELEASES, 'array_merge', []);
 $FEED_UPDATED =  0;
@@ -80,9 +82,10 @@
     $FEED_UPDATED = max($maxtime, $FEED_UPDATED);
 }
 
+$entries = ob_get_clean();
+
 $FEED_UPDATED = date(DATE_ATOM, max($FEED_UPDATED));
 
-echo <<<XML
-    <updated>{$FEED_UPDATED}</updated>
-</feed>
-XML;
+echo "    <updated>{$FEED_UPDATED}</updated>\n";
+echo $entries;
+echo "</feed>";

-- 
PHP Webmaster List Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to