Pull Request: https://github.com/php/web-php/pull/1017
Author: iansltx

Resolves #999

At some point in the past 12 years (this line was modified in the last 3 years 
but I doubt it got tested when modified) main.php.net started redirecting 
insecure HTTP to HTTPS, including for POSTs. The catch with those redirects is 
that POSTs won't get resubmitted when redirected, so when submitting an event 
the redirect would result in a GET with no parameters to the event submission 
endpoint, hence "Missing parameters." So event submission has been broken since 
main.php.net started redirecting HTTP to HTTPS.

Back in 2012 there was an attempt to switch this and other URLs to HTTPS, but 
it got rolled back because "there could be mirrors without ssl support." (see 
blame for the line this commit modifies). Since then, mirrors have been phased 
out, so we can safely assume we're calling HTTPS endpoints now (and that's the 
only way this will work anyway).

Verified by hitting the mentioned endpoint both on HTTP and HTTPS. HTTP gets 
redirected and fails due to missing parameters, HTTPS makes it through to the 
next step.

Reply via email to