Hi Smokey, your input and feedback is much appreciated. PHPDevShell V4 is an absolutely amazing leap forward. Although the code is not public it will very soon be. Regarding the documentation and everything else. We will be moving V4 to github and use its doc wiki for documentation. I think this will be a huge step forward regarding contributed development. PHPDevShell V4 aims to go back to basics and does not mean to do more than it is suppose to because of our small team we can only get so much done.
Make no mistake, we are very aware of attention needed in many areas, but we are a small team, been working on PHPDevShell for many years now and try to reach every issue as it is discovered. Would you be willing to join the team and help resolve issue within your own time and as you see fit? It is always great to have another voice on the team? -- You received this bug notification because you are a member of PHPDevShell, which is subscribed to PHPDevShell. https://bugs.launchpad.net/bugs/1117723 Title: USER_getGroupsQuery and USER_getRolesQuery give back very wrong results in some cases Status in Open Source PHP RAD Framework with UI.: Confirmed Bug description: Both methods are written without really taking into account that they might be called to get informations about another user, not the logged in one. PHPDS->USER_getRolesQuery() checks $this->user->mergeRoles and abandons further database checks if that field is not empty. It also writes informations to $this->user->mergeRoles, so the results of the first user checked by this query will be the only result given back by it in future calls. And I'm pretty sure $this->user->mergeRoles should return only current users roles. PHPDS->USER_getGroupsQuery() does exactly the same with $this->user->mergeGroups, and further more it gives back the main group more than once (this is because $group_string will contain the main group after checking it for childs. $group_main shouln't be merged with $group_string after this). Also, $group_array is an array resonse from a query. It should be extended with $group_array[] = array('user_group_id' => $group_main), not $group_array[$group_main] = array('user_group_id' => $group_main) To test this just run $this->userGetRoles($userid) or $this->userGetGroups($userid) for 2 different users. To manage notifications about this bug go to: https://bugs.launchpad.net/phpdevshell/+bug/1117723/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~phpdevshell Post to : [email protected] Unsubscribe : https://launchpad.net/~phpdevshell More help : https://help.launchpad.net/ListHelp
