Replying to the orinial letter, as this is the most clean
to start with :))
> 1. I had a look on the Chapter Features/Persistent Database
> connections. There should be explicitly stated, when persistent
> connections are closed or ending: webserver or/and database
> server shutdown. I think, this point is not clear enough.
Add this there if you feel this is missing.
>
> 2. mysql_pconnect: here also should be mentioned, when persistent
> connections are closed.
Add there a link to the persistent connections part IMHO.
> MySQL-Section:
> In general: links to the mysql related settings in php.ini
> may be sometimes usefull, e.g. at mysql_pconnect
> (php.ini mysql.allow_persistent = On/Off)
> Or the general hint (and link)in the description that the behaviour of
the
> mysql-functions might be influenced by settings in the php.ini
> If there are settings for MySQL in php.ini a call to mysql_connect()
> (with no parameters) is affected. And this becomes true for all
> function calls with no link identifier spezified (but required).
Add this :) It would help our readers IMHO.
> Examples:
> 1. mysql_db_query() is used by some code-examples. This is not
> conform with the note at mysql_db_query.
Remove from examples (see Derick's post for the reason :).
> 2. one more word on the examples (from the english manual):
> mysql_connect("mysql_host", "mysql_login", "mysql_password")
> mysql_connect ("kraemer", "marliesle", "secret")
> mysql_connect ("localhost", "username", "secret")
> mysql_pconnect ("kron", "jutta", "geheim")
> mysql_connect('dbhost', 'username', 'password');
> mysql_connect("marliesle");
> mysql_connect ($host, $user, $password);
> mysql_connect('localhost', 'myname', 'secret');
> mysql_connect("localhost", "username", "password");
>
> Using always the same syntax may improve understanding?
> I prefer the first.
I think we should not put a space after the function name
and before the ( char. See the PEAR standards about this
thing. That space is used with control structures and
"functions" called without parenthesis (echo, print, include...).
This is not a major issue. Changing all the connect
parts to be the same is IMHO not a good idea, as people
always copy-paste [sure!] and think this is the only way...
Goba
