Hello!
Hi Jakub ;)


I'm sending some patches for math section. It can be summarized like
that:

there's some problem with your patch :


abs: returns number, not mixed
we don't use "number" but "int" or "float"

atan2: there was small first letter in <refpurpose>
ok

*dec: see also other *dec functions
dec*: see also other dec* functions

perhaps I'm picky, but we (try to) always do :


See also <function>func1</function>,
<function>func1</function>,
<function>func2</function>,
   [..]
<function>func6</function> and
<function>func7</function>.

log1p: bad word-division in <refpurpose>

ok


srand, mt_srand: seed becomes optional in PHP 4.2.0

+ <parameter>seed</parameter> becomes optional + in PHP 4.2.0. If the <parameter>seed</parameter> + is not specified the most random seed possible is generated.

considering the fact that the word "seed" was used twice in the sentence before, there's too much redundancy here. Maybe you can rephrase the whole paragraph or rename the parameter ? for example (my english sucks) :

<para>
 <function>mt_srand</function> seeds the random number generator with
 <parameter>foo</parameter>.
</para>
<para>
 Since <literal>PHP</literal> 4.2.0, the <parameter>foo</parameter> is
 optionnal and defaults to a random seed generated by
 <literal>PHP</literal> if ommited.
</para>


(don't use foo as name ;))


      <parameter>seed</parameter>.
+     <parameter>seed</parameter> becomes optional
+     in PHP 4.2.0. If the <parameter>seed</parameter>
+     is not specified the most random seed possible is generated.


round: in fact, this function doesn't round halves to the nearest even value as stated

didn't verify it, but someone else will speak if you are wrong :)


no news with your CVS account request ?

Oh yes, something else : I'm not sure but if you name your patch "stg.txt" it will be displayed inline with your message in most mail reader (mine, btw ;)). It will be a little be handy to quick view it.

Keep the good work !

didou

Reply via email to