goba            Thu Jan  1 09:31:00 2004 EDT

  Modified files:              
    /phpdoc/scripts/quickref    originalafter.js processafter.php 
  Log:
  We have turned off autocomplete too late, so put the setting code before the focus 
event as suggested and verified by a user (http://bugs.php.net/26142)
  
Index: phpdoc/scripts/quickref/originalafter.js
diff -u phpdoc/scripts/quickref/originalafter.js:1.8 
phpdoc/scripts/quickref/originalafter.js:1.9
--- phpdoc/scripts/quickref/originalafter.js:1.8        Wed Dec 31 11:07:12 2003
+++ phpdoc/scripts/quickref/originalafter.js    Thu Jan  1 09:31:00 2004
@@ -13,8 +13,10 @@
 fh_matchesjoined="";
 fh_currenttext="";
 
+// form shortcuts and autocomplete setting on input field
 var f_p=_d.forms[0].pattern;
 var f_s=_d.forms[0].show;
+fh_EDropDownChange();
 
 // Layer setup -----------------------------------------------------------------
 
@@ -186,14 +188,11 @@
 
 function fh_EFocus()
 {
-    if (f_s.value=="quickref") {
-        f_p.setAttribute("autocomplete", "off");
-        fh_NewText();
-    }
+    if (f_s.value=="quickref") {fh_NewText();}
 }
 
-function fh_EBlur() { setTimeout("fh_EBlurT()", 200); }
-function fh_EBlurT() { f_p.setAttribute("autocomplete", "on"); fh_HideAll(); }
+// Timeout, so the user can click on a link before it disappears
+function fh_EBlur() { setTimeout("fh_HideAll()", 200); }
 
 function fh_EKeyPress(ev)
 {
@@ -267,6 +266,16 @@
     return true;
 }
 
+// turn off browser's built in autocomplete if in quickref mode
+function fh_EDropDownChange(ev)
+{
+    if(f_s.value=="quickref") {
+      f_p.setAttribute("autocomplete", "off");
+    } else {
+      f_p.setAttribute("autocomplete", "on");
+    }
+}
+
 // Event listener setup --------------------------------------------------------
 
 f_p.onkeypress=fh_EKeyPress;
@@ -274,3 +283,4 @@
 f_p.onblur=fh_EBlur;
 f_p.onkeydown=fh_EKeyDown;
 f_p.onkeyup=fh_EKeyUp;
+f_s.onchange=fh_EDropDownChange;
\ No newline at end of file
Index: phpdoc/scripts/quickref/processafter.php
diff -u phpdoc/scripts/quickref/processafter.php:1.5 
phpdoc/scripts/quickref/processafter.php:1.6
--- phpdoc/scripts/quickref/processafter.php:1.5        Wed Dec 31 19:35:41 2003
+++ phpdoc/scripts/quickref/processafter.php    Thu Jan  1 09:31:00 2004
@@ -16,7 +16,7 @@
   | Authors:    Mitja Slenc <[EMAIL PROTECTED]>                              |
   +----------------------------------------------------------------------+
   
-  $Id: processafter.php,v 1.5 2004/01/01 00:35:41 goba Exp $
+  $Id: processafter.php,v 1.6 2004/01/01 14:31:00 goba Exp $
 */
 
 $lines=file("originalafter.js");
@@ -24,7 +24,7 @@
        $lines[$key]=array_shift(explode("//", trim($line)));
 }
 
-$leave=array("cpd", "dcp", "for", "document", "forms", "break", "if", "continue", 
"var", "style", "innerHTML", "value", "getElementById", "autocomplete", "onblur", 
"onfocus", "onkeyup", "onkeydown", "onkeypress", "display", "pattern", "show", "left", 
"top", "event", "evt", "ev", "which", "length", "all", "navigator", "userAgent", 
"toLowerCase", "indexOf", "width", "else", "write", "split", "join", "charAt", 
"substring", "function", "return", "new", "Array", "switch", "case", "push", "pop", 
"default", "true", "false", "offsetLeft", "offsetParent", "while", "null", "tagName", 
"clientLeft", "parseInt", "border", "isNaN", "getAttribute", "charCode", "keyCode", 
"cc", "setTimeout", "fh_EBlurT", "setAttribute");
+$leave=array("cpd", "dcp", "for", "document", "forms", "break", "if", "continue", 
"var", "style", "innerHTML", "value", "getElementById", "onblur", "onfocus", 
"onkeyup", "onkeydown", "onkeypress", "onchange", "display", "pattern", "show", 
"left", "top", "event", "evt", "ev", "which", "length", "all", "navigator", 
"userAgent", "toLowerCase", "indexOf", "width", "else", "write", "split", "join", 
"charAt", "substring", "function", "return", "new", "Array", "switch", "case", "push", 
"pop", "default", "true", "false", "offsetLeft", "offsetParent", "while", "null", 
"tagName", "clientLeft", "parseInt", "border", "isNaN", "getAttribute", "charCode", 
"keyCode", "cc", "setTimeout", "fh_EBlurT", "setAttribute");
 
 $text=implode(" ", $lines);
 

Reply via email to