This mail is probably spam. The original message has been attached along with this report, so you can recognize or block similar unwanted mail in future. See http://spamassassin.org/tag/ for more details.
Content preview: [this message may have been sent out twice; the previous message has a bogus email address; my apologies] Thanks; looks good, although I'd prefer it if we didn't have too many special cases going on. [...] Content analysis details: (5.70 points, 5 required) NO_REAL_NAME (0.8 points) From: does not include a real name IN_REP_TO (-0.5 points) Has a In-Reply-To header HTML_00_10 (1.2 points) BODY: Message is 0% to 10% HTML HTML_MESSAGE (0.1 points) BODY: HTML included in message FORGED_MUA_OUTLOOK (3.5 points) Forged mail pretending to be from MS Outlook MISSING_OUTLOOK_NAME (0.6 points) Message looks like Outlook, but isn't
--- Begin Message ---[this message may have been sent out twice; the previous message has a bogus email address; my apologies] Thanks; looks good, although I'd prefer it if we didn't have too many special cases going on. You have an RTL constant to indicate that the content is RTL, but then there are a number of places where you use that to generate a dir="rtl" attribute. It would be better to define a DIRECTION constant that held dir="rtl" or dir="ltr" as appropriate for the language, and use that unconditionally. Likewise for the copyright text in style_mapping.php; just fold it into a single line that includes the directionality in any case: return sprintf('<p><DEFANGED_div dir="ltr" class="copyright">Copyright © %s by <DEFANGED_span %s>%s</DEFANGED_span></p><DEFANGED_div>', implode(", ", $y), DIRECTION, $holder); The other thing I noticed was that you have: $map['emphasis'] = 'format_emphasis'; but then: function format_em($node) { ... } --Wez. -----Original Message----- From: moshe doron [mailto:[EMAIL PROTECTED] Sent: 05 May 2004 19:14 To: [EMAIL PROTECTED] Subject: [PHP-DOC] [PATCH] rtl... "Wez Furlong" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > > Now, quit complaining and get coding ;-) > > --Wez. > http://moshe.i-com-it.com/patchs/livedocs-rtl3.patch.txt this patch contains: 1. initial rtl support. 2. add some missing htmlspecialchars(). i change the htmlentities(); on <pre> into htmlspecialchars() coz htmlentities(); doesn't fit well for not english charsets, do i miss something? --/moshe
--- End Message ---
