> Hey Nuno,
>
> I left out those other parts because:
>
> 1/ lookup_title() is good thing to use (take a look at what it does)
Oh, it is caching the results.... But SPL, Tidy,... don't work.
Mine implementation fetches the title and the description with one DB query
instead of two that you would do with the call of lookup_title
Maybe I could use that cache in my implementation, too. Not dificult to do.
> 2/ Although I want to solve the dom problem, I don't want to hard code dom
> specifics into the guts of livedocs
So how? How do you know if you to append 'dom-' to the id?
> 3/ the version stuff is not phpdoc specific; it can happily live in the
> default theme.
No! PHPDOC is the only using the version stuff. With your modified patch, it
works perfectly, because you are doing:
if ($q && LATEST_VERSION == $q) {
and I think the correct version would be:
if (!$q || LATEST_VERSION == $q) {
because If there is no version information on the DB, it is considered as
'CVS only', so it is only avaliable in latest version.
> Sorry to be a pain, but can you list the specific issues that remain and
which
> parts of your patch fix those things?
>
> Part of the problem is that you're fixing too much in one patch, and it
makes
> it difficult to see what's what.
Sorry, but I have tons of patches to livedocs... :) The issues adressed in
the patch I sent are:
* fixed a small problem with the message for outdated translations
* fetch english entites if the translated aren't avaliable (in
bind_entities)
* a fix for references pages, like SPL or Tidy (make_function_link)
* fix PCRE problem (handle_include)
* hard-coded a fix for dom
* small improvement for format_listing_hyperlink_function (don't link a
function if $id== $current_page)
I think thats all! ;-)
Nuno
> Thanks,
>
> --Wez.
