Hi Philip, thanks for the pointers.
I've never started from the skel, before, much less the new skel, much less for a PECL extension, and one that isn't bundled.
I appreciate the help/critique.
You have the following written out in each functions description:
Returns &true; on success, &false; on failure.
> As well as in each return values section (where it > should only belong) as the &return.success; entity.
Yep. Copy & paste error. Fixed.
Also, the docs suggest this can only be shared; can't it instead be compiled into PHP as well? On a related
note we need a faq on using phpize. Anyone? :)
Lastly, using &pecl.windows.download; seems appropriate.
Agreed. Can we come up with something standard for PECL, non-bundled extensions? See http://livedocs.phpdoc.info/classkit this isn't enough info, IMHO. Maybe something about the pear method, and another about phpize?
P.S. Be sure to edit both manual.xml.in files (one's in the RFC folder)
This is intentional, I was going to mention this, but you beat me to it. I suspect that the doc build will ignore classkit if it stays out of manual.xml, correct? I'd like a little peer review (confidence) before including it by default.
Anything else? I really AM looking for "you did this wrong", or "do it like this:", etc.
I created the self-manipulation entity, did I handle that properly?
Lastly, I think we should create an entity for: <note> <simpara> This parameter is only used as of PHP 5, because, prior to this, all methods were public. </simpara> </note>
Opinions?
S
