* Thus wrote Derick Rethans:
> On Mon, 23 Aug 2004, Curt Zirzow wrote:
> 
> >
> > For livedoc specific changes, i've tried to keep it as general as
> > possible, so other themes can easily be added/modified
> > appropriately.
> >
> > Patch #1:
> > =========
> > http://zirzow.dyndns.org/patches/livedocs/navigation.patch
> ...
> 
> As I wrote before, the images should be in the livedocs module so that
> we don't have to depend on external machines. So don't use
> static.php.net here.

Sorry, i missed that.  Does that also apply to the websites css
files as well? My orginal intent was to keep modfication to
standard php.net files to a minium.


> Besides that indenting is totally messed. Please make sure to use the
> same style of indenting for code that you add.

egads.. I dont know how I missed that.

> 
> 
> > Patch #2
> > ========
> > http://zirzow.dyndns.org/patches/livedocs/css.phptheme.patch
> >
>...
> 
> 1. Why did you remove my margin: 0px; from "body"?
> 2. We should not hard code font sizes.

All due to a lack of attention to detail, I had to merge my patch
manually and failed miserably.

> 3. Why did you remove all styles for a.*?

The reason for this, is because php.net's css already defines
these.

> 
> and your whitespace is generally "fucked up" :)

Nicely put :) Sorry for such a bad patch.

Curt
-- 
First, let me assure you that this is not one of those shady pyramid schemes
you've been hearing about.  No, sir.  Our model is the trapezoid!

Reply via email to