On Wednesday 08 September 2004 02:46, Leonardo Boshell wrote: > Hello Yannick, > > > I have made some modifications on revcheck script. > > (...) > > What do you think about it ? > > Nice work! The collapse/expand functionality is interesting, and it's > great that the resulting document is xhtml-1.0-compliant now. > > Even though I tend to dislike the idea of using javascript to present > HTML, your implementation is straightforward enough and doesn't seem to > affect presentation on browsers that lack javascript support. I just > have two small comments: > > a) The links on the top of the page point to "javascript(0)" which, in > my opinion, is more of a not-very-elegant hack, and is not friendly with > text-only browsers.
Yes, it's just a first approach of what i think ;) I'm going to work on this again. > > b) Related to that, when you click on one of those links, the > corresponding section collapses/expands, but the browser doesn't scroll > to that place (as it works with a traditional `#' anchor). So if I want > to look at "Untranslated files", for example, I click the box, and then > have to scroll down manually to read that section. Good. I also will integrate that > > > I wish I could help you with that, but I don't really code in > javascript, so I'm not sure what would be a clean solution for those > issues. Apart from that, it's a nice improvement, and I like it. Thanks :) > > Thanks, -- Yannick
