Hi,
Thanks for the quick feedback :)
On Thu, 10 Aug 2006 23:28:04 +0100
[EMAIL PROTECTED] ("Nuno Lopes") wrote:
> some comments:
> * we don't use tabs in examples. only spaces (4). we strictly follow
> the PEAR standards.
> * we also don't use tabs for indentation
I think I converted now all tabs to spaces (I was already sure
before :D)
> * enchant_broker_describe() lacks documentation on some sections
Yes, I think so too, I will add the details about the array.
> * you aren't using the &return.success; entity. it could be used for
> example in enchant_broker_free()
Done, I did not know it, thanks for the tip :)
> * enchant_dict_check() needs some attention
Quite simple function but yes :)
> * there is a &example.outputs.similar; entity that should be used
> for example in enchant_broker_list_dicts().
Done
> * strange example in enchant_dict_quick_check():
> if (enchant_broker_dict_exists($r,$tag)) {
> }
> // nothing to do there?
Fixed, removed the wrong line from my "general test script".
> there are also a couple of typos, but we'll squash them later.
You are nice to say that there is only "a couple" ;-)
> I think thats all for now :)
Good enough :)
I updated the html pages and the tgz
Thanks again,
--Pierre
