This one time, at band camp, Mehdi Achour <[EMAIL PROTECTED]> wrote:

Yes, Hannes commited his patch.
See the imagesetpixel.xml file.

seems to be missing some OO goodness for extensions with a OOP interface.

This si what I have now..
http://phpro.org/sandbox/readimage.xml

Kevin

some comments:
in the returnvalues section you say: "Returns &true; on success". You are missing the full-stop and you aren't saying what it returns on failure (maybe just an exception?). You may want to use the &return.success; entity here. In the example you use realpath. Why so? the extension should be smart enough to figure it out. You also include an image as the output of the example, but why? the example does nothing but loading an external image and printing a string (as it seems), so printing a random image is really pointless.

Nuno

Reply via email to