Hi,

I did a cursory review of the commit and it's ok, except the following (repeated several times):

+    <programlisting role="php">
+<![CDATA[
+#!/usr/local/bin/php
+<?php

I don't really like the shebang there, nor I do think it should go into the examples. Please remove that.

Thanks,
Nuno


----- Original Message ----- From: "Logan Buesching" <[EMAIL PROTECTED]>
To: <phpdoc@lists.php.net>
Sent: Thursday, May 03, 2007 7:03 PM
Subject: [PHP-DOC] cvs: phpdoc /en/reference/posix/functions posix-ctermid.xml posix-get-last-error.xml posix-getcwd.xml posix-getegid.xml posix-geteuid.xml posix-getgid.xml posix-getgrgid.xml posix-getgrnam.xml posix-getgroups.xml posix-getlogin.xml posix-getpgid.xml posix-getpgrp.xml posix-getpid.xml posix-getppid.xml posix-getpwnam.xml posix-getpwuid.xml posix-getrlimit.xml posix-getsid.xml posix-getuid.xml posix-isatty.xml posix-setegid.xml posix-setgid.xml posix-setuid.xml posix-strerror.xml posix-times.xml posix-ttyname.xml posix-uname.xml


ljbuesch Thu May  3 18:03:25 2007 UTC

 Modified files:
   /phpdoc/en/reference/posix/functions posix-ctermid.xml
                                       posix-get-last-error.xml
                                       posix-getcwd.xml
                                       posix-getegid.xml
                                       posix-geteuid.xml
                                       posix-getgid.xml
                                       posix-getgrgid.xml
                                       posix-getgrnam.xml
                                       posix-getgroups.xml
                                       posix-getlogin.xml
                                       posix-getpgid.xml
                                       posix-getpgrp.xml
                                       posix-getpid.xml
                                       posix-getppid.xml
                                       posix-getpwnam.xml
                                       posix-getpwuid.xml
                                       posix-getrlimit.xml
                                       posix-getsid.xml
                                       posix-getuid.xml
                                       posix-isatty.xml
                                       posix-setegid.xml
                                       posix-setgid.xml
                                       posix-setuid.xml
                                       posix-strerror.xml
                                       posix-times.xml
                                       posix-ttyname.xml
                                       posix-uname.xml
 Log:
Committing accepted patch for POSIX functions. This includes documentation for many of the undocumented POSIX functions and adds examples to previously documented functions.

Reply via email to