On Jul 24, 2007, at 3:07 PM, Xavier De Cock wrote:

Sorry it's my first time documentation, and I'd firstly posted a patch as
requested which as waited 2 days without response or comments.

So I tried to build the doc and found no error.

My mother language is French (as we can see in the comments of the
extension i must translate them to English) so, I'll try to give more
attention to typos, thanks for the patch.

The extension must still evolve although it's able to do what we need some
operations and limits are still in it so the documentation will be
enhanced. I'll try to use vi to edit the next versions because I see some
tabs in the files.

I hope this documentation will be useful (I'll translate it to French, and
try to make less typos :/)

It's okay, these things happen. Just be sure to check your unified diffs over and over before commit because phpdoc is picky about whitespace. Whether something sits around for a day or three before commit isn't a big deal, there is no rush. I apologize for not responding to your review request especially after requesting it be done. But thankfully there are many watchful eyes lurking about, like Maciek, that are here to help each other out.

Regards,
Philip

Reply via email to