On Sat, Dec 27, 2008 at 00:39, Keryx Web <webmas...@keryx.se> wrote: > The main markup errors I found (taking a cursory glance) are: > > (a) using the target attribute to open links (also in user notes) in a new > window, which requires the frameset DTD. This should really be avoided. Most > users find such behavior annoying.
I find it really annoying clicking on links that don't open another domain in new tabs. There is nothing more natural then to add target to links leading away from the current site. Common courtesy if you ask me. > (c) > <input type="image" > src="http://static.php.net/www.php.net/images/small_submit.gif"; > id="changeLangImage" alt="" /> > > Missing alt-text. Should be something like "change language" (i.e. > describing function, not looks.) This is *not* a decorative image. Fine. Fixed. Firefox doesn't display the value though. > The main problem is all the inline styles in the PHP-markup. Ironically, > they only exist in the proper manual. User submitted code is marked up using > classes! Sic! Documentation highlighting is done via hilight_string() in PhD, user submitted code is done in phpweb via modified highlight_string(). Guess we can steal that function... > (d) Notes are marked up as blockquotes. They are not quotes. Ouh? The user said these things, why is that not a quote? > (e) Headings in the notes are marked up with the b-element, when they really > should be headings. This is "bed and breakfast" markup. <b> + <br> where a > heading is the right element fir the job. You mean the "<small>User Contributed Notes</small><strong>page-name</strong>"? > Minor gripes: > > (a) Anorectic anchors: > > <a name="87685"></a> > <div class="note"> > > Should be shortened to: > > <div id="87685" class="note"> Browser don't support it. They don't even support <a name="..." />... and IDs cannot be integers, but names can :) > (b) The strong element is used to produce bold text, even though no emphasis > is intended. When the heading is repeated above the user contributed notes > it should be marked up as a heading. Not using strong. > > Users that contribute notes should not be put in bold using strong either. > > In fact HTML 5 *recommends* using the <b> element for exactly such usage: > http://www.whatwg.org/specs/web-apps/current-work/#the-cite-element Confusing. This back and forth is annoying. Make up your mind people. > (c) Concerns all of php.net > > Using vertical bars to separate links in a menu was actually recommended - > in the 90's! Today such a list should be marked up *as a list* and styled You got that right. The markup of php.net has not changed since late 90s.. > (d) Redundant classes? > > <p class="para"> Are there any plain <p>'s? Yes. See all pages, except for the manual. > <em class="emphasis"> When is <em> not used to denote emphasis? This is application generated markup. It *must* to be possible to distinguish docs/generated markup to regular markup. > BTW, I changed the heading of this thread. Using XHTML or HTML is a non > issue. Except for not-cutting-edge-browsers ;) -Hannes
![http://static.php.net/www.php.net/images/small_submit.gif"](http://static.php.net/www.php.net/images/small_submit.gif"){kind=link}