On Wed, Feb 11, 2009 at 15:51, Richard Quadling <rquadl...@googlemail.com> wrote: > 2009/2/11 Christian Weiske <cwei...@cweiske.de>: >> Hi Richard! >> >> >>> >> OK. But this class is breaking the links. They all now have an MD5 >>> >> hash in the html/php output and are not copied to the correct location >>> >> (actually not copied at all). >>> > >>> > They are not copied because they are referenced wrongly now in the >>> > manual itself. Their fileref needs to be relative to the manual.xml >>> > location. >>> >>> Aha! Just for those at the back (ahem), that means whereas it is currently >>> ... >>> figures/imagick.hello_world.png >>> this would become >>> en/reference/imagick/figures/hello_world.png >> Exactly.
Right. Christian and I have talked a little about this on IRC. The current phpdoc implementation of this is flat out wrong. It is unnecessary complicated and makes it technically impossible for a renderer to copy images, which is why we always have had and extra step to do so "manually". As Christian has implemented PhD now does the "Right Thing". phpdoc needs to change its markup. The current file locations are however still fine. I like the way they are now, all we have to change is the fileref="" (and removing the legacy manual image copying). >>> There are just over 40 images at the moment. I'll test this out and >>> make the necessary changes. Awesome > Currently there is a script which pulls all the images from the > various books into a single location. That should no longer be used. PhD does that if the fileref="" markup is correct. > Currently the filename includes the book (imagick.filename.extension), > which is workable. The original filenames? That is not how it used to be. The image names used to be the functionname it was demonstrating, see en/reference/image/figures. I think we should stick to the existing naming convention and file locations: en/reference/<extname>/figures/<funcname>[_n].<ext> i.e. en/reference/image/figures/imagecopyresampled.jpg en/reference/image/figures/imagecopyresampled_2.jpg and simply fix the fileref="" to be relative to the location of .manual.xml > So, I would keep "figures" rather than "images" unless the syncing of > the manual on mirrors can remove the existing "figures" folder (I > don't know about the mirroring processes). The rendered naming scheme is no problem. Be it figures/ or images/ is no issue. Our mirroring process does cleanup no-longer-existing-files as far as I know, as we do clean manual builds every Friday (removing the "old stuff" and then moving the "new" stuff in). -Hannes
