On Fri, Oct 2, 2009 at 18:42, Moacir de Oliveira <moacirdeoliveira....@gmail.com> wrote: > Patch for the Bug #49743 http://bugs.php.net/bug.php?id=49743 > > http://pastie.org/639588 > > This patch modify the structure of the table ids of the Indexer, a new auto > increment primary key is used instead of the docbook_id, and now the xml:ids > with multiple sdesc will be stored in the database.
The patch looks good (took a while to read the insert statement though ;)). But, is there any need for a primary key at all? Chunks which do not have xml:id, will they continue to work? Could you write a test case so we dont break this again? :) -Hannes
