2009/11/1 Richard Quadling <rquadl...@googlemail.com>: > 2009/10/30 Hannes Magnusson <hannes.magnus...@gmail.com>: >> 2009/10/30 Hannes Magnusson <hannes.magnus...@gmail.com>: >>> >>> >>> 2009/10/29 Richard Quadling <rquadl...@php.net>: >>>> rquadling Thu, 29 Oct 2009 11:04:46 +0000 >>>> >>>> Revision: http://svn.php.net/viewvc?view=revision&revision=290052 >>>> >>>> Log: >>>> Added VERBOSE_MISSING_ATTRIBUTES verbose level >>>> Separated PhD verbose messages into informational and warnings >>>> PhD verbose warning messages are coloured magenta >>>> Added MediaManger->findFile() method to return full filename of required >>>> image >>>> VERBOSE_MISSING_ATTRIBUTE message generated when missing one of the >>>> width/height attributes on imagedata >>>> VERBOSE_MISSING_ATTRIBUTE message generated when missing alt attributes on >>>> mediaobject > imagedata >>>> >>> >>> Kudos. >>> >>> Maybe add VERBOSE_ERROR, VERBOSE_WARNING and VERBOSE_INFO constants? Would >>> make it easier to only suppress/retrieve those specific messages.. >>> >> >> Also, this is hard to read: >> + v('Missing ' . (!$width ? 'width' : 'height') . ' >> attribute for ' . $file, VERBOSE_MISSING_ATTRIBUTES); >> >> v() supports variable arguments al'a printf()... >> >> -Hannes >> > > I'll take a look at this tomorrow (Monday). > > v('Missing %s attribute for %s", (!$width ? 'width' : 'height'), > $file, VERBOSE_MISSING_ATTRIBUTES); > > > and the grouping of error/warning/info. > > Thanks for the feedback. > > Richard. > -- > ----- > Richard Quadling > "Standing on the shoulders of some very clever giants!" > EE : http://www.experts-exchange.com/M_248814.html > Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 > ZOPA : http://uk.zopa.com/member/RQuadling >
I've sprintf'd the new v()s and corrected 2 already there. Also new verbose levels to group errors VERBOSE_ERRORS (PHP and User errors) VERBOSE_INFO (rendering, reading, writing, etc.) VERBOSE_WARNINGS (no version, broken links, missing attributes). Richard -- ----- Richard Quadling "Standing on the shoulders of some very clever giants!" EE : http://www.experts-exchange.com/M_248814.html Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 ZOPA : http://uk.zopa.com/member/RQuadling
