Thanks for you feedback. See my answers bellow 2009/11/7 Israel Ekpo <israele...@gmail.com>: > > > On Sat, Nov 7, 2009 at 10:44 AM, Pierrick Charron <pierr...@webstart.fr> > wrote: >> >> Hi, >> >> I created the documentation related to the stomp extension (I released >> yesterday the version 0.3.0 of it) and i would like to get some >> feedback on this documentation before pushing it online. >> >> You'll find the documentation here : http://php.adoy.net/stomp >> And the XML here : http://www.adoy.net/stomp/doc.tgz >> >> Thanks >> Pierrick > > > Hi Pierrick > > Requirements > ============ > If you want more people to participate in testing/using the extension, I > think you should try to do more regression tests against lower php versions > like 5.2.4 > Most people using PHP are still behind in terms of what they are using the > thier PROD environments.
I did some gression tests and the next version 0.3.1 will need PHP >= 5.2.2 instead of 5.2.10 > > Installation > ============= > You should make the installation instructions clearer instead of sending > them to another page > > Something like: > > ./configure --enable-stomp > > OR > > pecl install stomp-beta > > should be good enough. I added a small section quick install which just provide the pecl install command. Otherwise i prefere people to go to the officiel pecl installation documentation. > > I also thing you should prevent implicit conversion of (void *) when > performing dynamic memory allocation. > > It may cause the C++ based compilers to fail on Windows. I compiled the last version of the stomp extension on windows and it compiled with no error. The only warnings i got are due to php_smart_str.h (which i can't modify) > Examples > ============ > I prefer to use more realistic examples instead of "foo" and "bar". > PHP is used all over the world. Some people may not really follow. > -- > "Good Enough" is not good enough. > To give anything less than your best is to sacrifice the gift. > Quality First. Measure Twice. Cut Once. >
