On Dec 15, 2009, at 2:43 AM, Daniel Egeberg wrote: > I have attached patches to bugs #50311 and #50317. I also cleaned up > the strrpos() page while I was at it seeing as #50317 is about that > function.
Hello Daniel, And now for some nitpicking: #50317 It's preferred to use the changelog role instead of <notes> for changes. Granted this manual page already uses <note> for this, but since you're updating it then it may as well use the newer syntax. It's sibling strrchr() uses the changelog role, so it should help you see how it's done. #50311 Although you copied the format from the current manual, it's also something we do in places (but shouldn't). :) And that's writing 'you' within the manual. Maybe something more like "intval() should not be used on objects, as doing so will emit an E_NOTICE level error and return 1." although I wonder if that's always true. Seems to be: <?php $a = new DomDocument(); $b = intval($a); var_dump($b); ?> Notice: Object of class DOMDocument could not be converted to int int(1) What do you think? > I had been thinking about getting more involved in the PHP project > lately. Seeing as my C skills aren't too sharp I figured I'd start > with the documentation. Should I just apply for an SVN account now, or > should I keep sending in patches? I think you should apply for a SVN account, after you update your patches to cleanup the current docs. Regards, Philip
