On Wed, Jan 6, 2010 at 08:52, Hannes Magnusson
<hannes.magnus...@gmail.com> wrote:
> On Wed, Jan 6, 2010 at 03:59, Moacir de Oliveira
> <moacirdeoliveira....@gmail.com> wrote:
>> hi all,
>>
>> Here a patch to add support to DBTimestamp processing instructions to PhD
>>
>> Patch:
>> http://pastie.org/768355
>
> Looks good. I tested it with the zenddocs and it seems to work fine.
Out of curiosity, why does the ::PI section in Render.php not do the
same as all the others?
All other handlers do similar to:
foreach($this as $format) {
$parsed_value = $format->doStuff($with, $value);
if ($parsed_value === false) {
$format->appendData($orginal_value);
} else {
$format->appendData($parsed_value);
}
}
But with PI, you have to manually call $this->format->appendData()
from the PI handler.. it seems wrong.
-Hannes
