Le Dimanche 14 Mars 2010 16:38:18, KSChan a écrit :
> Hi Yannick,

Hi Kschan !

> 
> I took a look at codemirror and i believe optionally disable the highlight
> is not an easy task.

I have quickly read the doc and yes, you're right, not so easy.

> A quick fix for long documents is to split the highlight task.
> 
> In js/component/task/GetFileTask.js line 53,
> 
> we just split the contents by hundreds of lines, we use "insertIntoLine"
> (refer to codemirror doc [1])  instead of "setContent" and keep building
> the document incrementally by milliseconds.
> 
> If that's a good fix, i will complete it within days :p

Have you try it ?
I'm not on this file, if you want to commit a change, feel free ;)

PS : Some ideas for the GSOC ? ;)

Best,
Y.

> 
> ks.
> 
> [1] - http://marijn.haverbeke.nl/codemirror/manual.html
> 
> On Sat, Mar 13, 2010 at 12:36 AM, yannick <yannick.tor...@gmail.com> wrote:
> > Le Vendredi 12 Mars 2010 16:44:28, Yago Ferrer a écrit :
> > > Hi Yannick,
> > > I did login with my credentials. I cleaned cache as you said and I'm
> > 
> > having
> > 
> > > the same problem. When you double-click in the file I takes a long time
> > 
> > to
> > 
> > > try to open it:
> > > (/appendices/ini.xml from Error in current translation) and finally
> > > javascript crashes.
> > 
> > ini.xml is a big file (more than 5000 lines) and in module "Pending
> > Review",
> > this file is open twice ;)
> > 
> > > I believe is the function to highlight the code because when I'm
> > > opening the file is halfway highlighted.  Can we have this
> > > functionality as an option that you can activate / deactivate?
> > 
> > sur it is...
> > I must investigate if I can activate/deactivate the highlighting. The
> > file is
> > open directly into a codemirror component witch handle this. I must if
> > the component allow this or not. If I can do, I will propose an option
> > to automatically desable highlight if the file is more than 2000 lines,
> > for example.
> > 
> > Best,
> > Yannick
> > 
> > > Thanks!
> > > 
> > > On Thu, Mar 11, 2010 at 11:36 PM, yannick <yannick.tor...@gmail.com>
> > 
> > wrote:
> > > > Hi Yago,
> > > > 
> > > > I can't reproduice it.
> > > > 
> > > > Did you login in anonymous or with your VCS credentials ?
> > > > 
> > > > PS: try to clear your browser cache.
> > > > 
> > > > Best,
> > > > Yannick
> > > > 
> > > > Le Vendredi 12 Mars 2010 05:12:33, Yago Ferrer a écrit :
> > > > > I can help sending a bug I found.
> > > > > 
> > > > > Browser: Firefox 3.5.8
> > > > > OS: Fedora Linux
> > > > > 
> > > > > Error: Javascript crash on:
> > > > > http://edit.php.net/js/ux/codemirror/js/codemirror.js:270
> > > > > 
> > > > > How to reproduce it:
> > > > > Login as : Php Documentation
> > > > > Language: Spanish
> > > > > 
> > > > > Open tab: Error in current translation:
> > > > > Open folder: Appendices/
> > > > > Double click on ini.xml
> > > > > 
> > > > > 
> > > > > Yago
> > > > > 
> > > > > On Thu, Mar 11, 2010 at 6:23 PM, Philip Olson <phi...@roshambo.org>
> > > > 
> > > > wrote:
> > > > > > Hello everyone,
> > > > > > 
> > > > > > Before we go public with the online documentation editor, let's
> > > > > > all
> > > > 
> > > > make
> > > > 
> > > > > > a real effort to try it out. Please break it, and please use it
> > > > > > the
> > > > 
> > > > next
> > > > 
> > > > > > time (or three) you make a commit. We don't need test commits (it
> > > > 
> > > > works)
> > > > 
> > > > > > but real world usage. This applies to both translations and
> > 
> > English.
> > 
> > > > > > There are a few bug reports and more should exist. Feature
> > > > > > requests are also encouraged.
> > > > > > 
> > > > > > The editor is here:
> > > > > >  - http://edit.php.net/
> > > > > > 
> > > > > > Documentation for it:
> > > > > >  - http://wiki.php.net/doc/editor/
> > > > > > 
> > > > > > The source code:
> > > > > >  - http://svn.php.net/viewvc/web/doc-editor/trunk/
> > > > > > 
> > > > > > Notes:
> > > > > >  - Anyone (even anonymous) can create patches
> > > > > >  - Those with karma can commit their own and other peoples
> > > > > >  patches - Please check diffs before commit, as there may be
> > > > > >  whitespace
> > 
> > bugs
> > 
> > > > > >  - The PEAR manual is also selectable, but choose PHP ;)
> > > > > > 
> > > > > > Eventually we'll ask the world to create patches using this and
> > > > > > who
> > > > 
> > > > knows
> > > > 
> > > > > > where we'll go from there, but likely a good place.
> > > > > > 
> > > > > > Regards,
> > > > > > Philip

Reply via email to