On 6/18/2010 4:09 AM, Lorenzo Castelli wrote:
On Thu, 2010-06-17 at 18:30 +0200, Philip Olson wrote:
Looks good, and you now have the karma to commit. Welcome to the PHP
Documentation team :)
Thanks :)
A few minor issues that come to mind:
- The phrase "providing the perfect hashing function" ... perfect? ;)
As Daniel said, a perfect hashing function is a function that associates
a unique hash to each key in a static set. You can check the cmph link
(http://cmph.sourceforge.net/) for more information.
Hmmm, the problem is that phrasing sounds like you're saying "my hashing
function is perfect", not using a phrase that specifies a type of
hashing function.
I would suggest either linking to a definition of "perfect hashing" or
providing the definition after that paragraph or even just putting
quotation marks around the phrase so readers understand you're not
saying your hashing is the perfect way to hash, but rather referring to
a specific type of hashing function ;)
It might be standard terminology, but remember your average PHP audience
is not necessarily a computer science major.
- Lack of versions within versions.xml
Thanks, I've fixed this issue and committed the documentation.
Lorenzo Castelli
Thanks,
Elizabeth Smith
