Hi Jesús, Maciek, @Jesús : Have you an SVN account to commit into phpdoc ? or have you make this patch via an anonymous login (or Facebook/Googe account) ?
@Maciek : Could you file a bug report and indicate where you are not able to commit the patch, and where you are able to commit it ? About the bad english, sorry, but english isn't my native language. Tell me by mail all sentence isn't correct and the correct sentence. Best, Yannick 2012/2/29 Jesús Ruiz García <jesusruiz2...@gmail.com> > Thanks for your work Maciek ;) > > I really do not know how the patch works, so maybe the problem is we're > doing something wrong. If not, hopefully as you say a patch soon. > > Regards and thanks for everything. > > > 2012/2/29 Maciek Sokolewicz <maciek.sokolew...@gmail.com> > >> On 29-02-2012 16:54, Maciek Sokolewicz wrote: >> >>> On 28-02-2012 23:00, Jesús Ruiz García wrote: >>> >>>> Hello and thanks for reading this message. >>>> >>>> I created a patch, because I think there is an error in the >>>> documentation in the file: isOriginal, in the directory >>>> reference/ktaglib/**audioproperties. >>>> In the line <refpurpose> of isOriginal, indicates that returns the >>>> length of an MPEG file. Return the length of an MPEG file is responsible >>>> of getLenght. >>>> >>>> I do not know if the patch, I have to send to this address. Attached the >>>> patch, if any of you want to review it. >>>> >>>> A greeting and thanks. >>>> >>>> Jesús Ruiz >>>> jesusruiz2...@gmail.com >>>> <mailto:jesusruiz2007@gmail.**com<jesusruiz2...@gmail.com> >>>> > >>>> jesusr...@php.net <mailto:jesusr...@php.net> >>>> >>> >>> I just tried to validate and apply this patch via edit.php.net, but got >>> the message 'You can't change file's owner. You must be a global >>> administrator or an administrator for this lang.' >>> >>> However, when checking the Patches for Review section, I can select the >>> user jesusruiz and click commit patch. Which works fine. >>> >>> So one of both is incorrect. I personally think I should be able to >>> validate such a patch anyway, and if not, I would like to request karma >>> to be able to :) >>> >>> Anyway: the patch is committed. Thank you for supplying this patch. >>> >> >> On a side note, trying to reject a patch, I get: >> "The file you want to clear local change isn't own by you. >> You can only do this action for yours files." >> >> Now, obviously this is incorrect as well, and very likely related to the >> above problem (not to mention the hideous english). >> >> I'm actually thinking of going through the source for the editor and >> correcting all such grammar and spelling mistakes, I find them quite >> annoying to be honest. So expect a patch soon ;) >> > >
