On Sun, Jun 16, 2013 at 3:40 AM, Jeff Welch <whatthej...@gmail.com> wrote:
> Hi, all :) > > My name is Jeff Welch and I'm one of the maintainers of the PHPUnit > project. While investigating a PHPUnit issue ( > https://github.com/sebastianbergmann/phpunit-mock-objects/issues/130) > this past friday, I noticed that the PHP documentation is missing the > static modifier for a number of methods. I've created a patch ( > https://gist.github.com/whatthejeff/5790970) that adds the missing > modifier for the following methods: > > * `MessageFormatter::create` > * `MessageFormatter::formatMessage` > * `MessageFormatter::parseMessage` > * `mysqli::poll` > * `Phar::apiVersion` > * `Phar::canCompress` > * `Phar::canWrite` > * `Phar::createDefaultStub` > * `Phar::getSupportedCompression` > * `Phar::getSupportedSignatures` > * `Phar::interceptFileFuncs` > * `Phar::isValidPharFilename` > * `Phar::loadPhar` > * `Phar::mapPhar` > * `Phar::running` > * `Phar::mount` > * `Phar::mungServer` > * `Phar::unlinkArchive` > * `Phar::webPhar` > * `SQLite3::version` > * `SQLite3::escapeString` > > Anyway, it would be nice to get VCS access so I don't have to jump through > too many hoops for future contributions. > > PS: I've heard a love for cats will get you far with this list, so I > submit to you my cat-related open source contributions: > > * https://github.com/whatthejeff/nyancat-phpunit-resultprinter > * https://github.com/phpspec/phpspec/pull/133 > * https://github.com/whatthejeff/nyancat-scoreboard > > Hey you cheated. There was a dinosaur in there! Looks OK, but I suspect that it would be even better to add the visibility modifiers as long as you're adding the access modifiers. The documentation is currently wishy-washy about having those for all of the classes. Some have just the access and others have both visibility and access. If you'd be willing to help fix the rest that would be awesome and I'm sure the cats will give you bonus points for your VCS account. You also might want to take a look at https://edit.php.net If no one has any objections I'll go ahead and apply your patch later tonight. I admit I didn't look it over that thoroughly. > Thanks, > > - Jeff >
