Hi all, Sigurd Nes a écrit : >> From: Benoit Hamet [EMAIL PROTECTED] >> Sent: 2008-06-18 16:50:05 CEST >> To: phpgroupware-developers@gnu.org >> Subject: Re: [phpGroupWare-developers] Postres support -> Proposal >> >> Hi Sigurd, >> >> Sigurd Nes a écrit : >>>> From: Benoit Hamet [EMAIL PROTECTED] >>>> Sent: 2008-06-18 13:22:56 CEST >>>> To: phpgroupware-developers@gnu.org >>>> Subject: Re: [phpGroupWare-developers] Postres support / update DB to >>>> 0.9.18.015
<snip/> > > Then you will have support for pre 8.2 only - and that would be a sad > situation. > > and for mssql you will need something like (tested and working): > <code> > if(!isset($table) || $table == '' || !isset($field) || $field == '') > { > return -1; > } This case should never occured. If it's the case, then fix the calling code. Anyway, why the following code is not into adodb ??? > $result = @mssql_query("select @@identity", $this->adodb->_queryID); > if(!$result) > { > return -1; > } > return mssql_result($result, 0, 0); This should be contributed to adodb. Not use as a WA in our code ! > </code> > > That's my argument - don't know if it is a STRONG one :) > >> - class.schema_proc_pgsql.inc.php : well I'm not sure that these >> classes are still needed "like this" since they don't seems to use the >> adodb layer but use SQL directly ... so I thing that updating them >> should be done instead of only supporting a version of pgsql ... Will >> try to look at it now. >> > > In my experience - you can use adodb for some of it - but not everything - > expecting it to work for both pre and post 8.2 So to make it clear, adodb doesn't fully support pgsql > 8.2 nor mssql ? regards, Caeies _______________________________________________ phpGroupWare-developers mailing list phpGroupWare-developers@gnu.org http://lists.gnu.org/mailman/listinfo/phpgroupware-developers