Follow-up Comment #1, patch #4039 (project phpgroupware):
Hi Sigurd,
I don't have time to apply this before I go away for a week in the sun up
North.
Here is some comments based on a quick review:
phpgwapi/inc/class.db_mssql.inc.php
The variables are not needed as it should be "class db extends db_"
souldn't db::disconnect call mssql_close ?
Has the schema_proc changes been tested on any other RDBMS?
schema_proc_mssql, I think GetFKSQL is a new feature and so can't be included
into stable(16)
I don't understand why you have made the changes to class.setup.inc.php. Can
you explain?
The rest seems fine to me if anyone else has time to apply the patch. Please
do not apply the sections noted above without checking with me.
Cheers
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?func=detailitem&item_id=4039>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
Phpgroupware-tracker mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/phpgroupware-tracker
