Author: olga
Date: Wed Jul  2 15:05:47 2008
New Revision: 673522

URL: http://svn.apache.org/viewvc?rev=673522&view=rev
Log:
PIG-213: Remove non-static references to logger from data elements

Modified:
    incubator/pig/branches/types/CHANGES.txt
    incubator/pig/branches/types/src/org/apache/pig/data/DefaultDataBag.java
    incubator/pig/branches/types/src/org/apache/pig/data/DistinctDataBag.java
    incubator/pig/branches/types/src/org/apache/pig/data/SortedDataBag.java
    incubator/pig/branches/types/src/org/apache/pig/data/TimestampedTuple.java

Modified: incubator/pig/branches/types/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/incubator/pig/branches/types/CHANGES.txt?rev=673522&r1=673521&r2=673522&view=diff
==============================================================================
--- incubator/pig/branches/types/CHANGES.txt (original)
+++ incubator/pig/branches/types/CHANGES.txt Wed Jul  2 15:05:47 2008
@@ -130,3 +130,6 @@
 
        PIG-110: Replaced code accidently merged out in PIG-32 fix that handled
        flattening the combiner case. (gates and oae)
+
+    PIG-213: Remove non-static references to logger from data bags and tuples, 
+    as it causes significant overhead (vgeschel via gates).

Modified: 
incubator/pig/branches/types/src/org/apache/pig/data/DefaultDataBag.java
URL: 
http://svn.apache.org/viewvc/incubator/pig/branches/types/src/org/apache/pig/data/DefaultDataBag.java?rev=673522&r1=673521&r2=673522&view=diff
==============================================================================
--- incubator/pig/branches/types/src/org/apache/pig/data/DefaultDataBag.java 
(original)
+++ incubator/pig/branches/types/src/org/apache/pig/data/DefaultDataBag.java 
Wed Jul  2 15:05:47 2008
@@ -45,7 +45,7 @@
 
     private static TupleFactory gTupleFactory = TupleFactory.getInstance();
 
-    private final Log log = LogFactory.getLog(getClass());
+    private static final Log log = LogFactory.getLog(DefaultDataBag.class);
  
     public DefaultDataBag() {
         mContents = new ArrayList<Tuple>();

Modified: 
incubator/pig/branches/types/src/org/apache/pig/data/DistinctDataBag.java
URL: 
http://svn.apache.org/viewvc/incubator/pig/branches/types/src/org/apache/pig/data/DistinctDataBag.java?rev=673522&r1=673521&r2=673522&view=diff
==============================================================================
--- incubator/pig/branches/types/src/org/apache/pig/data/DistinctDataBag.java 
(original)
+++ incubator/pig/branches/types/src/org/apache/pig/data/DistinctDataBag.java 
Wed Jul  2 15:05:47 2008
@@ -56,7 +56,7 @@
      */
     private static final long serialVersionUID = 2L;
 
-    private final Log log = LogFactory.getLog(getClass());
+    private static final Log log = LogFactory.getLog(DistinctDataBag.class);
 
     private static TupleFactory gTupleFactory = TupleFactory.getInstance();
 

Modified: 
incubator/pig/branches/types/src/org/apache/pig/data/SortedDataBag.java
URL: 
http://svn.apache.org/viewvc/incubator/pig/branches/types/src/org/apache/pig/data/SortedDataBag.java?rev=673522&r1=673521&r2=673522&view=diff
==============================================================================
--- incubator/pig/branches/types/src/org/apache/pig/data/SortedDataBag.java 
(original)
+++ incubator/pig/branches/types/src/org/apache/pig/data/SortedDataBag.java Wed 
Jul  2 15:05:47 2008
@@ -55,7 +55,7 @@
 
     private static TupleFactory gTupleFactory = TupleFactory.getInstance();
 
-    private final Log log = LogFactory.getLog(getClass());
+    private static final Log log = LogFactory.getLog(SortedDataBag.class);
 
     private Comparator<Tuple> mComp;
     private boolean mReadStarted = false;

Modified: 
incubator/pig/branches/types/src/org/apache/pig/data/TimestampedTuple.java
URL: 
http://svn.apache.org/viewvc/incubator/pig/branches/types/src/org/apache/pig/data/TimestampedTuple.java?rev=673522&r1=673521&r2=673522&view=diff
==============================================================================
--- incubator/pig/branches/types/src/org/apache/pig/data/TimestampedTuple.java 
(original)
+++ incubator/pig/branches/types/src/org/apache/pig/data/TimestampedTuple.java 
Wed Jul  2 15:05:47 2008
@@ -30,7 +30,7 @@
      * 
      */
     private static final long serialVersionUID = 2L;
-    private final Log log = LogFactory.getLog(getClass());
+    private static final Log log = LogFactory.getLog(TimestampedTuple.class);
     static String defaultDelimiter = "[,\t]";
 
     protected double timestamp = 0;      // timestamp of this tuple


Reply via email to