[ 
https://issues.apache.org/jira/browse/PIG-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666679#action_12666679
 ] 

Santhosh Srinivasan commented on PIG-553:
-----------------------------------------

Review comments:

1. The code looks fine.
2. There are no unit test cases. We need unit test cases to ensure that the 
code path is exercised in all cases (preferably at least map reduce case)
3. In algebraic functions, since intermediate is called only in PigCombiner and 
the UDF visitor is never called in the PigCombiner, users should be aware that 
finish() is never called for intermediate methods. The UDF documentation has to 
be updated to reflect this caveat.

> EvalFunc.finish() not getting called
> ------------------------------------
>
>                 Key: PIG-553
>                 URL: https://issues.apache.org/jira/browse/PIG-553
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>         Environment: "local" mode
>            Reporter: Christopher Olston
>            Assignee: Shravan Matthur Narayanamurthy
>         Attachments: 553.patch
>
>
> My EvalFunc's finish() method doesn't seem to get invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to