[ 
https://issues.apache.org/jira/browse/PIG-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672425#action_12672425
 ] 

Olga Natkovich commented on PIG-574:
------------------------------------

I reviewed the patch and it looks good. I also ran unit tests and they all 
passed.

In addition, I ran some manual tests and have a couple of comments:

(1) As implemented now, scripts that ran from within grunt would not be able to 
take advantage of the parameter substitution as it is not available in the 
interactive mode. I think this is ok for now and we can revisit it later if 
users ask for it.
(2) When using run, I could integrate commands in my script with the 
interactive commands in the shell which was really nice; however, the commands 
from the script did not show in the command history. If it is reasonably easy 
to integrate, it would be nice to have that functionality.
(3) Very minor thing: after I execute ran command, I see double prompt from 
grant:

grunt> grunt>



> run command for grunt
> ---------------------
>
>                 Key: PIG-574
>                 URL: https://issues.apache.org/jira/browse/PIG-574
>             Project: Pig
>          Issue Type: New Feature
>          Components: grunt
>            Reporter: David Ciemiewicz
>            Priority: Minor
>         Attachments: run_command.patch
>
>
> This is a request for a "run file" command in grunt which will read a script 
> from the local file system and execute the script interactively while in the 
> grunt shell.
> One of the things that slows down iterative development of large, complicated 
> Pig scripts that must operate on hadoop fs data is that the edit, run, debug 
> cycle is slow because I must wait to allocate a Hadoop-on-Demand (hod) 
> cluster for each iteration.  I would prefer not to preallocate a cluster of 
> nodes (though I could).
> Instead, I'd like to have one window open and edit my Pig script using vim or 
> emacs, write it, and then type "run myscript.pig" at the grunt shell until I 
> get things right.
> I'm used to doing similar things with Oracle, MySQL, and R. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to