[ 
https://issues.apache.org/jira/browse/PIG-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678148#action_12678148
 ] 

Santhosh Srinivasan commented on PIG-684:
-----------------------------------------

Review Comment:

Index: src/org/apache/pig/builtin/TOKENIZE.java
======================================

The RuntimeException should have a reasonable error message. Otherwise it make 
it hard for users and developers to make sense of the exception. There are two 
possible options:

1. Include an appropriate message (preferred)
OR
2. return a NULL schema.

{code}
+            // throwing RTE because
+            //above schema creation is not expected to throw an exception
+            // and also because superclass does not throw exception
+            throw new RuntimeException();
{code}

> outputSchema method in TOKENIZE is broken
> -----------------------------------------
>
>                 Key: PIG-684
>                 URL: https://issues.apache.org/jira/browse/PIG-684
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: types_branch
>            Reporter: Santhosh Srinivasan
>            Assignee: Thejas M Nair
>             Fix For: types_branch
>
>         Attachments: PIG-684.txt
>
>
> The outputSchema method in TOKENIZE is broken. It should return a bag with a 
> tuple that contains a string and not just a string.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to