Thejas M Nair updated PIG-544:

    Attachment: 544.patch

Santhosh, Thanks for reviewing the changes and the suggestions.
The suggestions have been incorporated in this new patch, which replaces the 
old one.
Re: Index: 
  I have removed the changes in that as those are not necessary for fixing this 
JIRA. (I had accidentally included it in the patch.). It will be useful to fix 
similar problem described in PIG-696 .

Re: The semantics of bytearray to numeric types, a best effort conversion will 
be done. ie if there are minimum number of bytes required for the conversion, 
it will convert the bytearray to the specified number type.

> Utf8StorageConverter.java does not always produce NULLs when data is malformed
> ------------------------------------------------------------------------------
>                 Key: PIG-544
>                 URL: https://issues.apache.org/jira/browse/PIG-544
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Thejas M Nair
>             Fix For: types_branch
>         Attachments: 544.patch, PIG-544.txt
> It does so for scalar types but not for complext types and not for the fields 
> inside of the complext types.
> This is because it uses different code to parse scalar types by themselves 
> and scalar types inside of a complex type. It should really use the same (its 
> own code to do so.)
> The code it is currently uses, is inside of TextDataParser.jjt and is also 
> used to parse constants so we need to be careful if we want to make changes 
> to it.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to