[ 
https://issues.apache.org/jira/browse/PIG-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682340#action_12682340
 ] 

Santhosh Srinivasan commented on PIG-693:
-----------------------------------------

1. If you deprecate the constructors then you need to re-instate the private 
member variables. You can ignore this comment considering the fact that all 
uses of this class are inside Pig for now.

2. Ok. Its fine for now.

3. Changing name() will have implications on existing test cases. Its better to 
use node.getClass().geSimpletName(). Its more user friendly than using the 
node.toString() which provides details which cannot be understood by users.

4. Do not use i.toString(). Just use the following:

{code}
Integer i = null;
System.out.println(i);
{code}

> Parameter to UDF which is an alias returned in another UDF in nested foreach 
> causes incorrect results
> -----------------------------------------------------------------------------------------------------
>
>                 Key: PIG-693
>                 URL: https://issues.apache.org/jira/browse/PIG-693
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 1.0.0
>            Reporter: Viraj Bhat
>            Assignee: Thejas M Nair
>         Attachments: 693.patch, 693.utest.patch, one.txt, REPLACEALL.java, 
> URLDECODE.java
>
>
> Consider the following Pig Script
> {code}
> register myudf.jar;
> A = load 'one.txt' using PigStorage() as ( one: int ); --use this dummy file 
> to start execution
> B = foreach A {
>         dec = myudf.URLDECODE('hello');
>         str1 = myudf.REPLACEALL(dec, '[\\u0000-\\u0020]', ' '); -- ERROR
>         str2 = myudf.REPLACEALL('hello', '[\\u0000-\\u0020]', ' ');
>         generate
>                 dec,
>                 str1,
>                 str2;
>         };
> describe B;
> dump B;
> {code}
> where one.txt is a file which contains number one (1) for starting execution 
> of the Pig script!!
> {code}
> describe B; 
> {code}
>  returns the following:
> B: {urldecode_9: chararray,replaceall_urldecode_10_11: 
> chararray,replaceall_12: chararray}
> {code}
> dump B;
> {code}
> returns 
> (hello,[\u0000-\u0020],hello)
> The result should be:
> There is a workaround for the same, 
> {code}
> register myudf.jar;
> A = load 'one.txt' using PigStorage() as ( one: int );
> B = foreach A {
>         dec = myudf.URLDECODE('hello');
>         generate
>                 dec as dec,
>                 myudf.REPLACEALL(dec, '[\\u0000-\\u0020]', ' ') as str1,
>                 myudf.REPLACEALL('hello', '[\\u0000-\\u0020]', ' ') as str2;
>         };
> describe B;
> dump B;
> {code}
> where 
> {code}
> dump B;
> {code}
> returns (hello,hello,hello)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to